From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, crosa@redhat.com, ehabkost@redhat.com,
muriloo@linux.vnet.ibm.com, armbru@redhat.com,
Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v11 7/8] qemu.py: launch vm only if it's not running
Date: Tue, 14 Nov 2017 11:22:45 +0100 [thread overview]
Message-ID: <20171114102246.22221-8-apahim@redhat.com> (raw)
In-Reply-To: <20171114102246.22221-1-apahim@redhat.com>
If we allow launching VM again we will loose track of the first launched
VM.
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Amador Pahim <apahim@redhat.com>
---
scripts/qemu.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 305d7bd098..0b0b61be39 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -207,6 +207,9 @@ class QEMUMachine(object):
Launch the VM and make sure we cleanup and expose the
command line/output in case of exception
"""
+ if self.is_running():
+ raise QEMUMachineError('VM already running')
+
self._iolog = None
self._qemu_full_args = None
try:
--
2.13.6
next prev parent reply other threads:[~2017-11-14 10:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 10:22 [Qemu-devel] [PATCH v11 0/8] scripts/qemu.py fixes and cleanups Amador Pahim
2017-11-14 10:22 ` [Qemu-devel] [PATCH v11 1/8] qemu.py: remove unused import Amador Pahim
2018-01-19 17:26 ` Eduardo Habkost
2017-11-14 10:22 ` [Qemu-devel] [PATCH v11 2/8] qemu.py: better control of created files Amador Pahim
2018-01-19 17:26 ` Eduardo Habkost
2017-11-14 10:22 ` [Qemu-devel] [PATCH v11 3/8] qemu.py: refactor launch() Amador Pahim
2018-01-19 17:29 ` Eduardo Habkost
2017-11-14 10:22 ` [Qemu-devel] [PATCH v11 4/8] qemu.py: always cleanup on shutdown() Amador Pahim
2018-01-19 17:33 ` Eduardo Habkost
2017-11-14 10:22 ` [Qemu-devel] [PATCH v11 5/8] qemu.py: use poll() instead of 'returncode' Amador Pahim
2018-01-19 17:37 ` Eduardo Habkost
2017-11-14 10:22 ` [Qemu-devel] [PATCH v11 6/8] qemu.py: cleanup redundant calls in launch() Amador Pahim
2018-01-19 17:37 ` Eduardo Habkost
2017-11-14 10:22 ` Amador Pahim [this message]
2018-01-19 17:51 ` [Qemu-devel] [PATCH v11 7/8] qemu.py: launch vm only if it's not running Eduardo Habkost
2017-11-14 10:22 ` [Qemu-devel] [PATCH v11 8/8] qemu.py: don't launch again before shutdown() Amador Pahim
2018-01-19 17:52 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114102246.22221-8-apahim@redhat.com \
--to=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=famz@redhat.com \
--cc=muriloo@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.