From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@intel.com>,
Piotr Luc <piotr.luc@intel.com>, Kan Liang <kan.liang@intel.com>,
Borislav Petkov <bp@suse.de>,
Stephane Eranian <eranian@google.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
He Chen <he.chen@linux.intel.com>,
Mathias Krause <minipli@googlemail.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: [PATCH v6 0/3] Fix panic in logical packages calculation
Date: Tue, 14 Nov 2017 07:42:54 -0500 [thread overview]
Message-ID: <20171114124257.22013-1-prarit@redhat.com> (raw)
A system booted with a small number of cores enabled per package
panics because the estimate of __max_logical_packages is too low.
This occurs when the total number of active cores across all packages
is less than the maximum core count for a single package.
Andi noted that the logical_packages calculation wastes 128k on 64-bit
x86 systems and posted patches to fix the allocation. His patches
result in significant memory size savings, and I have put my
fix on top of those patches.
Here's an example of the panic:
smpboot: Booting Node 1, Processors #1 OK
smpboot: Package 1 of CPU 1 exceeds BIOS package data 1.
------------[ cut here ]------------
kernel BUG at arch/x86/kernel/cpu/common.c:1087!
invalid opcode: 0000 [#1] SMP
Modules linked in:
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.14.0-rc2+ #4
This was tested by dropping the number of active cores across
all packages to reproduce the bug above. Additional testing included
2 socket and 4 socket systems and hotplugging entire sockets in different
order.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Piotr Luc <piotr.luc@intel.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Stephane Eranian <eranian@google.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: He Chen <he.chen@linux.intel.com>
Cc: Mathias Krause <minipli@googlemail.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Andi Kleen (2):
perf/x86/intel/uncore: Cache logical pkg id in uncore driver
x86/topology: Avoid wasting 128k for package id array
Prarit Bhargava (1):
x86/smpboot: Fix __max_logical_packages estimate
arch/x86/events/intel/uncore.c | 4 +-
arch/x86/events/intel/uncore.h | 2 +-
arch/x86/events/intel/uncore_snbep.c | 2 +-
arch/x86/include/asm/processor.h | 1 +
arch/x86/kernel/smpboot.c | 130 +++++++++++------------------------
5 files changed, 44 insertions(+), 95 deletions(-)
--
2.15.0.rc0.39.g2f0e14e64
next reply other threads:[~2017-11-14 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 12:42 Prarit Bhargava [this message]
2017-11-14 12:42 ` [PATCH v6 1/3] perf/x86/intel/uncore: Cache logical pkg id in uncore driver Prarit Bhargava
2017-11-17 15:27 ` [tip:x86/urgent] " tip-bot for Andi Kleen
2017-11-14 12:42 ` [PATCH v6 2/3] x86/topology: Avoid wasting 128k for package id array Prarit Bhargava
2017-11-17 14:59 ` Thomas Gleixner
2017-11-17 15:27 ` [tip:x86/urgent] " tip-bot for Andi Kleen
2017-11-14 12:42 ` [PATCH v6 3/3] x86/smpboot: Fix __max_logical_packages estimate Prarit Bhargava
2017-11-17 15:27 ` [tip:x86/urgent] " tip-bot for Prarit Bhargava
2018-02-07 18:44 ` [v6,3/3] " Simon Gaiser
2018-02-07 19:04 ` Prarit Bhargava
2018-02-07 19:26 ` [v6, 3/3] " Simon Gaiser
2018-02-07 19:26 ` [v6,3/3] " Simon Gaiser
2018-02-07 19:31 ` [v6, 3/3] " Prarit Bhargava
2018-02-07 19:31 ` [v6,3/3] " Prarit Bhargava
2018-02-07 19:04 ` [v6, 3/3] " Prarit Bhargava
2018-02-07 18:44 ` Simon Gaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114124257.22013-1-prarit@redhat.com \
--to=prarit@redhat.com \
--cc=ak@linux.intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=eranian@google.com \
--cc=he.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kan.liang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=peterz@infradead.org \
--cc=piotr.luc@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.