From: Bryan Tan <bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: RDMA mailing list
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>,
Benjamin Drung
<benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Subject: Re: vmw_pvrdma: Add SRQ support - broke rdma-core
Date: Tue, 14 Nov 2017 11:25:12 -0800 [thread overview]
Message-ID: <20171114192510.GA6083@bryantan-devbox.prom.eng.vmware.com.prom.eng.vmware.com> (raw)
In-Reply-To: <20171114190029.GI18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Tue, Nov 14, 2017 at 09:00:29PM +0200, Leon Romanovsky wrote:
> On Tue, Nov 14, 2017 at 08:27:20PM +0200, Leon Romanovsky wrote:
> > On Tue, Nov 14, 2017 at 10:51:43AM +0200, Leon Romanovsky wrote:
> > > The commit 25f07300bfb7 ("vmw_pvrdma: Add SRQ support") causes to build
> > > failures in Travis CI [1] and on my system too [2].
> > >
> > > Please fix.
> >
> > I reverted the commit, please fix compilation error and resubmit.
> >
> > Commit: 32bf4efb8605 ("Revert "vmw_pvrdma: Add SRQ support" because it causes build failures")
>
> Just as a pointer, it fails on the systems with kernel's include/uapi/rdma/vmw_pvrdma-abi.h
> file available, so fixup is not applied but without your definition yet.
Thanks for the notice, I should have tried building on a kernel without
the updated ABI header. We had a question though, what would be the best
approach to fix this? We didn't bump up the ABI version after discussion
on the pull request. Is there a way for the fixup to be included if
there is an ABI version mismatch, or if a macro is not defined (in this
case, PVRDMA_UAR_SRQ_OFFSET)? I thought that we'd use the fixup over the
ABI header exposed by the kernel, but my assumption there was wrong.
> > Thanks
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-14 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 8:51 vmw_pvrdma: Add SRQ support - broke rdma-core Leon Romanovsky
[not found] ` <20171114085143.GS18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-14 18:27 ` Leon Romanovsky
[not found] ` <20171114182720.GC18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-14 19:00 ` Leon Romanovsky
[not found] ` <20171114190029.GI18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-14 19:25 ` Bryan Tan [this message]
[not found] ` <20171114192510.GA6083-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-11-14 19:28 ` Jason Gunthorpe
[not found] ` <20171114192858.GM4263-uk2M96/98Pc@public.gmane.org>
2017-11-15 2:49 ` Bryan Tan
[not found] ` <20171115024924.GA23574-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-11-15 3:15 ` Jason Gunthorpe
[not found] ` <20171115031526.GJ25894-uk2M96/98Pc@public.gmane.org>
2017-11-15 22:10 ` Bryan Tan
[not found] ` <20171115221052.GA16946-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-11-16 5:21 ` Leon Romanovsky
[not found] ` <20171116052119.GF18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-16 18:54 ` Bryan Tan
[not found] ` <20171116185450.GB16946-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-11-17 23:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114192510.GA6083@bryantan-devbox.prom.eng.vmware.com.prom.eng.vmware.com \
--to=bryantan-pghwnbhtmq7qt0dzr+alfa@public.gmane.org \
--cc=benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.