From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Kernel-team@fb.com
Subject: Re: [PATCH] blkcg: correctly update stat
Date: Tue, 14 Nov 2017 13:03:26 -0800 [thread overview]
Message-ID: <20171114210326.GS983427@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <2fefc7364715a5c7d928fd02e4edeb7f80633c7f.1510682654.git.shli@fb.com>
On Tue, Nov 14, 2017 at 10:05:07AM -0800, Shaohua Li wrote:
> blkcg_bio_issue_check() checks throtl for stat update, which isn't good
> because the bio could be splitted into small bios, the samll bios go
> into blkcg_bio_issue_check again and we update stat for the small bios,
> so we the stat is double charged. To fix this, we only update stat if
> the bio doesn't have BIO_THROTTLED flag. The fix will update stat ahead
> of bio skips from blk-throttle, but eventually the stat is correct.
>
> This patch is on top of patch:
> https://marc.info/?l=linux-block&m=151060860608914&w=2
>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Shaohua Li <shli@fb.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2017-11-14 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 18:05 [PATCH] blkcg: correctly update stat Shaohua Li
2017-11-14 21:03 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114210326.GS983427@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.