From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Prateek Sood <prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
boqun.feng-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sramana-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] cgroup/cpuset: remove circular dependency deadlock
Date: Wed, 15 Nov 2017 09:05:24 -0800 [thread overview]
Message-ID: <20171115170524.GU983427@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171115103742.xt7muaq2dfrs2cyd-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
On Wed, Nov 15, 2017 at 11:37:42AM +0100, Peter Zijlstra wrote:
> On Wed, Nov 15, 2017 at 03:56:26PM +0530, Prateek Sood wrote:
> > Any improvement/suggestion for this patch?
>
> I would have done 2 patches, the first one solving the locking issue,
> the second removing the then redundant async rebuild stuff.
>
> Other than that this looks OK I suppose, but I was expecting this to go
> through the cgroup tree, TJ?
Will pick them up after -rc1.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Prateek Sood <prsood@codeaurora.org>,
longman@redhat.com, lizefan@huawei.com, mingo@kernel.org,
boqun.feng@gmail.com, tglx@linutronix.de,
cgroups@vger.kernel.org, sramana@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cgroup/cpuset: remove circular dependency deadlock
Date: Wed, 15 Nov 2017 09:05:24 -0800 [thread overview]
Message-ID: <20171115170524.GU983427@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171115103742.xt7muaq2dfrs2cyd@hirez.programming.kicks-ass.net>
On Wed, Nov 15, 2017 at 11:37:42AM +0100, Peter Zijlstra wrote:
> On Wed, Nov 15, 2017 at 03:56:26PM +0530, Prateek Sood wrote:
> > Any improvement/suggestion for this patch?
>
> I would have done 2 patches, the first one solving the locking issue,
> the second removing the then redundant async rebuild stuff.
>
> Other than that this looks OK I suppose, but I was expecting this to go
> through the cgroup tree, TJ?
Will pick them up after -rc1.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-11-15 17:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 13:56 [PATCH] cgroup/cpuset: remove circular dependency deadlock Prateek Sood
2017-09-07 17:45 ` Peter Zijlstra
2017-09-08 2:13 ` Prateek Sood
[not found] ` <1504792583-10424-1-git-send-email-prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-09-07 17:51 ` Peter Zijlstra
2017-09-07 17:51 ` Peter Zijlstra
2017-10-09 13:27 ` Prateek Sood
[not found] ` <4668d1ec-dc43-8a9c-4f94-a421683d3c17-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-10-09 13:32 ` Prateek Sood
2017-10-11 9:48 ` Peter Zijlstra
2017-10-11 9:48 ` Peter Zijlstra
[not found] ` <20171011094833.pdp4torvotvjdmkt-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-10-25 8:39 ` Prateek Sood
2017-10-25 8:39 ` Prateek Sood
2017-10-25 9:30 ` Peter Zijlstra
[not found] ` <20171025093041.GO3165-IIpfhp3q70x9+YH6RuovlLjjLBE8jN/0@public.gmane.org>
2017-10-26 11:52 ` Prateek Sood
2017-10-26 11:52 ` Prateek Sood
2017-10-26 14:05 ` Waiman Long
[not found] ` <dc80ad9d-5b3d-b991-76c8-35630bc139c5-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-27 8:03 ` Prateek Sood
2017-10-27 8:03 ` Prateek Sood
[not found] ` <45cdac2f-4462-e5b5-d724-8cca58e3932a-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-10-30 7:16 ` [PATCH v2] " Prateek Sood
2017-10-30 7:16 ` Prateek Sood
[not found] ` <1509347805-23491-1-git-send-email-prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-06 4:01 ` Prateek Sood
2017-11-06 4:01 ` Prateek Sood
2017-11-15 10:26 ` Prateek Sood
2017-11-15 10:26 ` Prateek Sood
[not found] ` <6f8b194f-05ec-05d4-3df6-e9eadc7f68bf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-15 10:37 ` Peter Zijlstra
2017-11-15 10:37 ` Peter Zijlstra
[not found] ` <20171115103742.xt7muaq2dfrs2cyd-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-11-15 14:20 ` [PATCH v3 0/2] Invert cpu_hotplug_lock and cpuset_mutex locking order Prateek Sood
2017-11-15 14:20 ` Prateek Sood
[not found] ` <1510755615-25906-1-git-send-email-prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-15 14:20 ` [PATCH v3 1/2] cgroup/cpuset: remove circular dependency deadlock Prateek Sood
2017-11-15 14:20 ` Prateek Sood
2017-11-15 14:20 ` [PATCH v3 2/2] cpuset: Make cpuset hotplug synchronous Prateek Sood
2017-11-15 14:20 ` Prateek Sood
2017-11-27 16:48 ` [PATCH v3 0/2] Invert cpu_hotplug_lock and cpuset_mutex locking order Tejun Heo
2017-11-15 17:05 ` Tejun Heo [this message]
2017-11-15 17:05 ` [PATCH v2] cgroup/cpuset: remove circular dependency deadlock Tejun Heo
[not found] ` <20171115170524.GU983427-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-11-15 17:18 ` Prateek Sood
2017-11-15 17:18 ` Prateek Sood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115170524.GU983427@devbig577.frc2.facebook.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=boqun.feng-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=prsood-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=sramana-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.