From: Oleg Nesterov <oleg@redhat.com>
To: Yonghong Song <yhs@fb.com>
Cc: mingo@kernel.org, tglx@linutronix.de, peterz@infradead.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
netdev@vger.kernel.org, ast@fb.com, kernel-team@fb.com
Subject: Re: [PATCH][v3] uprobes/x86: emulate push insns for uprobe on x86
Date: Wed, 15 Nov 2017 18:07:34 +0100 [thread overview]
Message-ID: <20171115170734.GA12415@redhat.com> (raw)
In-Reply-To: <20171115154707.GB21275@redhat.com>
On 11/15, Oleg Nesterov wrote:
>
> So please, check if uprobe_init_insn() fails or not in this case. After that
> we will know whether your patch needs the additional is_64bit_mm() check in
> push_setup_xol_ops() or not.
OK, I did the check for you.
uprobe_init_insn() doesn't fail but insn_init(x86_64 => 0) parse it as
single-byte insn with OPCODE1 == 0x41, so push_setup_xol_ops() doesn't
need to worry about compat tasks.
In short, your "V2" should be fine except you can factor out
auprobe->push.ilen initialization (as you did in V3). Please send V4.
Oleg.
next prev parent reply other threads:[~2017-11-15 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 22:11 [PATCH][v3] uprobes/x86: emulate push insns for uprobe on x86 Yonghong Song
2017-11-14 15:51 ` Oleg Nesterov
2017-11-14 16:03 ` Oleg Nesterov
2017-11-14 22:43 ` Yonghong Song
2017-11-15 15:47 ` Oleg Nesterov
2017-11-15 17:07 ` Oleg Nesterov [this message]
2017-11-15 17:25 ` Yonghong Song
2017-11-14 22:35 ` Yonghong Song
2017-11-15 15:38 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115170734.GA12415@redhat.com \
--to=oleg@redhat.com \
--cc=ast@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.