From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@kernel.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
kernel-team@fb.com, lizefan@huawei.com, hannes@cmpxchg.org,
cgroups@vger.kernel.org, guro@fb.com
Subject: Re: [PATCH v2 3/7] blkcg: associate a request with its blkcg_gq instead of request_list
Date: Wed, 15 Nov 2017 09:11:18 -0800 [thread overview]
Message-ID: <20171115171118.GV983427@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171114231743.2eprnbfmgesqc42c@kernel.org>
Hello,
On Tue, Nov 14, 2017 at 03:17:43PM -0800, Shaohua Li wrote:
> After patch 5, we don't really need the blk_put_rl, blk_get_rl, blk_rq_set_rl
> functions. I'd like to delete them and only keep blk_rq_rl. The name
> blk_rq_set_rl is confusing too.
Yeah, we can switch the legacy rq to switch to direct blkg pinning
too. If that cleans up the code, great.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-11-15 17:11 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 22:26 [PATCHSET] blkcg: basic accounting and throttling fixes Tejun Heo
2017-11-12 22:26 ` Tejun Heo
2017-11-12 22:26 ` [PATCH 1/7] blkcg: relocate __blkg_release_rcu() Tejun Heo
[not found] ` <20171112222613.3613362-2-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-14 23:12 ` Shaohua Li
2017-11-14 23:12 ` Shaohua Li
2017-11-12 22:26 ` [PATCH 2/7] blkcg: use percpu_ref for blkcg_gq->refcnt Tejun Heo
[not found] ` <20171112222613.3613362-3-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-14 23:12 ` Shaohua Li
2017-11-14 23:12 ` Shaohua Li
2017-11-12 22:26 ` [PATCH 3/7] blkcg: associate a request with its blkcg_gq instead of request_list Tejun Heo
2017-11-13 20:15 ` [PATCH v2 " Tejun Heo
2017-11-13 20:15 ` Tejun Heo
[not found] ` <20171113201523.GM983427-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-11-14 23:17 ` Shaohua Li
2017-11-14 23:17 ` Shaohua Li
2017-11-15 17:11 ` Tejun Heo [this message]
2017-11-12 22:26 ` [PATCH 4/7] blkcg: refactor blkcg_gq lookup and creation in blkcg_bio_issue_check() Tejun Heo
[not found] ` <20171112222613.3613362-5-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-14 23:18 ` Shaohua Li
2017-11-14 23:18 ` Shaohua Li
[not found] ` <20171112222613.3613362-1-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-12 22:26 ` [PATCH 5/7] blkcg: associate blk-mq requests with the matching blkcg_gqs Tejun Heo
2017-11-12 22:26 ` Tejun Heo
2017-11-12 22:26 ` [PATCH 6/7] blkcg: account requests instead of bios for request based request_queues Tejun Heo
[not found] ` <20171112222613.3613362-7-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-14 23:23 ` Shaohua Li
2017-11-14 23:23 ` Shaohua Li
[not found] ` <20171114232355.vjxlzfbqbqj5ihq4-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-15 17:18 ` [PATCH v2 " Tejun Heo
2017-11-15 17:18 ` Tejun Heo
2017-11-15 17:19 ` [PATCH " Jens Axboe
2017-11-15 17:19 ` Jens Axboe
[not found] ` <9a2ddc6a-d618-a896-290c-254ffeb5e9d6-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2017-11-15 17:22 ` [PATCH v3 " Tejun Heo
2017-11-15 17:22 ` Tejun Heo
2017-11-12 22:26 ` [PATCH 7/7] blk-throtl: don't throttle the same IO multiple times Tejun Heo
[not found] ` <20171112222613.3613362-8-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-13 4:07 ` Shaohua Li
2017-11-13 4:07 ` Shaohua Li
[not found] ` <20171113040716.kaheegc4qub42n6z-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-13 11:13 ` Tejun Heo
2017-11-13 11:13 ` Tejun Heo
[not found] ` <20171113111348.GF983427-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-11-13 15:57 ` Tejun Heo
2017-11-13 15:57 ` Tejun Heo
[not found] ` <20171113155745.GI983427-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-11-13 19:54 ` Shaohua Li
2017-11-13 19:54 ` Shaohua Li
[not found] ` <20171113195413.b5lzqem2pt2bg4oe-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-13 19:58 ` Tejun Heo
2017-11-13 19:58 ` Tejun Heo
2017-11-13 19:58 ` Shaohua Li
2017-11-13 19:58 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115171118.GV983427@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.