From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] drm: mali-dp: Separate static internal data into a read-only structure. Date: Wed, 15 Nov 2017 17:23:59 -0200 Message-ID: <20171115192359.GA5486@jade> References: <20171101141317.3052-1-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id F31FD6E6AB for ; Wed, 15 Nov 2017 19:24:05 +0000 (UTC) Received: by mail-qt0-f193.google.com with SMTP id e19so32118203qte.8 for ; Wed, 15 Nov 2017 11:24:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171101141317.3052-1-Liviu.Dudau@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: David Airlie , LKML , DRI-devel , Mali DP Maintainers , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org SGkgTGl2aXUsCgoyMDE3LTExLTAxIExpdml1IER1ZGF1IDxMaXZpdS5EdWRhdUBhcm0uY29tPjoK Cj4gVGhlIG1hbGlkcF9od19kZXZpY2Ugc3RydWN0dXJlIHRoYXQgdGhlIGRyaXZlciB1c2VzIHRv IGhhbmRsZSB0aGUKPiBkaWZmZXJlbmNlcyBiZXR3ZWVuIHZlcnNpb25zIG9mIHRoZSBJUCBjb250 YWlucyBib3RoIG5vbi1jaGFuZ2VhYmxlCj4gZGF0YSBhbmQgZmllbGRzIHRoYXQgZ2V0IHVwZGF0 ZWQgYXQgcHJvYmUgdGltZS4gUHJldmlvdXNseSB3ZSB3ZXJlCj4gY29weWluZyB0aGUgcmVhZC1v bmx5IHBhcnQgaW50byBhbGxvY2F0ZWQgbWVtb3J5LCBidXQgdGhhdCBjYW4gYmUKPiBjb21wbGV0 ZWx5IGF2b2lkZWQgYnkgc3BsaXR0aW5nIHRoZSBzdHJ1Y3R1cmUgaW50byBhIHJlYWQtb25seSBw YXJ0Cj4gYW5kIGtlZXBpbmcgdGhlIHJ1bnRpbWUgbW9kaWZpYWJsZSBmaWVsZHMgaW50byB0aGUg b2xkIHN0cnVjdHVyZS4KPiAKPiBSZXZpZXdlZC1ieTogQnJpYW4gU3RhcmtleSA8YnJpYW4uc3Rh cmtleUBhcm0uY29tPgo+IFNpZ25lZC1vZmYtYnk6IExpdml1IER1ZGF1IDxsaXZpdS5kdWRhdUBh cm0uY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9jcnRjLmMgICB8IDEz ICsrKystLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2Rydi5jICAgIHwgMzAgKysr KysrKystLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfaHcuYyAgICAgfCA0 NiArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlk cF9ody5oICAgICB8IDY1ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMgfCAxOSArKysrKy0tLS0tLQo+ICA1 IGZpbGVzIGNoYW5nZWQsIDkzIGluc2VydGlvbnMoKyksIDgwIGRlbGV0aW9ucygtKQoKUmV2aWV3 ZWQtYnk6IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jb20+CgpH dXN0YXZvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758872AbdKOTYR (ORCPT ); Wed, 15 Nov 2017 14:24:17 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:56246 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753740AbdKOTYF (ORCPT ); Wed, 15 Nov 2017 14:24:05 -0500 X-Google-Smtp-Source: AGs4zMbNQtR3xhys4GnVvPgKed/D3W3jlVVYi+7p4vIw9KmOfyKtr+g5RG3RWe3dzvAFQh/oX59sYg== Date: Wed, 15 Nov 2017 17:23:59 -0200 From: Gustavo Padovan To: Liviu Dudau Cc: Brian Starkey , David Airlie , LKML , DRI-devel , Mali DP Maintainers , Daniel Vetter Subject: Re: [PATCH] drm: mali-dp: Separate static internal data into a read-only structure. Message-ID: <20171115192359.GA5486@jade> References: <20171101141317.3052-1-Liviu.Dudau@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171101141317.3052-1-Liviu.Dudau@arm.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liviu, 2017-11-01 Liviu Dudau : > The malidp_hw_device structure that the driver uses to handle the > differences between versions of the IP contains both non-changeable > data and fields that get updated at probe time. Previously we were > copying the read-only part into allocated memory, but that can be > completely avoided by splitting the structure into a read-only part > and keeping the runtime modifiable fields into the old structure. > > Reviewed-by: Brian Starkey > Signed-off-by: Liviu Dudau > --- > drivers/gpu/drm/arm/malidp_crtc.c | 13 ++++---- > drivers/gpu/drm/arm/malidp_drv.c | 30 ++++++++--------- > drivers/gpu/drm/arm/malidp_hw.c | 46 ++++++++++++++------------ > drivers/gpu/drm/arm/malidp_hw.h | 65 ++++++++++++++++++++++--------------- > drivers/gpu/drm/arm/malidp_planes.c | 19 +++++------ > 5 files changed, 93 insertions(+), 80 deletions(-) Reviewed-by: Gustavo Padovan Gustavo