From: Andrew Lunn <andrew@lunn.ch>
To: Eran Ben Elisha <eranbe@mellanox.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"John W. Linville" <linville@tuxdriver.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Gal Pressman <galp@mellanox.com>,
Ariel Almog <ariela@mellanox.com>,
Inbar Karmy <inbark@mellanox.com>
Subject: Re: [RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool
Date: Thu, 16 Nov 2017 02:07:22 +0100 [thread overview]
Message-ID: <20171116010722.GD2130@lunn.ch> (raw)
In-Reply-To: <1510772411-17054-1-git-send-email-eranbe@mellanox.com>
On Wed, Nov 15, 2017 at 09:00:09PM +0200, Eran Ben Elisha wrote:
> From: Inbar Karmy <inbark@mellanox.com>
>
> This RFC adds support for configuring PFC stall prevention through ethtool.
>
> In the event where the device unexpectedly becomes unresponsive for a long
> period of time, flow control mechanism may propagate pause frames which will
> cause congestion spreading to the entire network.
>
> To prevent this scenario, the device may implement a protection mechanism for
> monitoring and resolving such state. The following patches allow the user to
> control the stall prevention functionality.
>
> PFC stall prevention configuration is done via ethtool -a (pause).
> Two modes are introduced:
> Default - current behavior per driver.
> Auto - protection mechanism controlled automatically by the driver.
Why Auto?
Down in the driver you seem to translate this to a time. And it looks
like your hardware is flexible on that time, it can probably do at
least 8s to 100ms.
Why not specify a time?
What do other vendors support? Time? Number of pause frames sent?
Andrew
next prev parent reply other threads:[~2017-11-16 1:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 19:00 [RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool Eran Ben Elisha
2017-11-15 19:00 ` [RFC PATCH net-next 1/2] ethtool: Add support for configuring PFC stall prevention in ethtool Eran Ben Elisha
2017-11-15 19:00 ` [RFC PATCH net-next 2/2] net/mlx5e: PFC stall prevention support Eran Ben Elisha
2017-11-16 1:07 ` Andrew Lunn [this message]
2017-11-16 2:44 ` [RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool Andrew Lunn
2017-11-16 9:17 ` Eran Ben Elisha
2017-11-16 15:22 ` Andrew Lunn
2017-11-16 8:44 ` Michal Kubecek
2017-11-16 12:03 ` Eran Ben Elisha
2017-11-16 12:39 ` Michal Kubecek
2017-11-16 15:42 ` Andrew Lunn
2017-11-20 11:47 ` Eran Ben Elisha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116010722.GD2130@lunn.ch \
--to=andrew@lunn.ch \
--cc=ariela@mellanox.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=galp@mellanox.com \
--cc=inbark@mellanox.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.