From mboxrd@z Thu Jan 1 00:00:00 1970 From: Flavio Leitner Date: Thu, 16 Nov 2017 04:56:46 +0000 Subject: Re: [PATCH] rtnetlink: fix missing size for IFLA_IF_NETNSID Message-Id: <20171116025646.3327d157@plex.home> List-Id: References: <20171106150454.9623-1-colin.king@canonical.com> <20171106161620.7080cf66@redhat.com> In-Reply-To: <20171106161620.7080cf66@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jiri Benc Cc: Colin King , "David S . Miller" , David Ahern , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, 6 Nov 2017 16:16:20 +0100 Jiri Benc wrote: > On Mon, 6 Nov 2017 15:04:54 +0000, Colin King wrote: > > The size for IFLA_IF_NETNSID is missing from the size calculation > > because the proceeding semicolon was not removed. Fix this by removing > > the semicolon. > > Acked-by: Jiri Benc > > Thanks for spotting this! Looking at my initial code, I had that right, > this was probably introduced during one of rebases, so I blame > Flavio :-p (On a serious note, thank you, Flavio, for taking care of > the rebases.) That's right, ouch! Thanks for fixing it. -- Flavio From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933534AbdKPFM3 (ORCPT ); Thu, 16 Nov 2017 00:12:29 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21097 "EHLO sender-of-o51.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbdKPFMP (ORCPT ); Thu, 16 Nov 2017 00:12:15 -0500 Date: Thu, 16 Nov 2017 02:56:46 -0200 From: Flavio Leitner To: Jiri Benc Cc: Colin King , "David S . Miller" , David Ahern , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtnetlink: fix missing size for IFLA_IF_NETNSID Message-ID: <20171116025646.3327d157@plex.home> In-Reply-To: <20171106161620.7080cf66@redhat.com> References: <20171106150454.9623-1-colin.king@canonical.com> <20171106161620.7080cf66@redhat.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ZohoMailClient: External Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Nov 2017 16:16:20 +0100 Jiri Benc wrote: > On Mon, 6 Nov 2017 15:04:54 +0000, Colin King wrote: > > The size for IFLA_IF_NETNSID is missing from the size calculation > > because the proceeding semicolon was not removed. Fix this by removing > > the semicolon. > > Acked-by: Jiri Benc > > Thanks for spotting this! Looking at my initial code, I had that right, > this was probably introduced during one of rebases, so I blame > Flavio :-p (On a serious note, thank you, Flavio, for taking care of > the rebases.) That's right, ouch! Thanks for fixing it. -- Flavio