From: Stephen Hemminger <stephen@networkplumber.org>
To: Ilya Matveychikov <matvejchikov@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/2] mbuf: reset nb_segs of chained packet
Date: Thu, 16 Nov 2017 09:01:55 -0800 [thread overview]
Message-ID: <20171116090155.31419fe3@xeon-e3> (raw)
In-Reply-To: <AB67A84E-B83C-49C3-AA48-8ACA06E24B39@gmail.com>
On Thu, 16 Nov 2017 18:05:35 +0400
Ilya Matveychikov <matvejchikov@gmail.com> wrote:
> Fixes: 139debc42dc0 ("mbuf: move chaining from ip_frag library")
> Cc: simon.kagstrom@netinsight.net
>
> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index ce8a05ddf..2126dc94b 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1828,9 +1828,12 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail
> head->nb_segs += tail->nb_segs;
> head->pkt_len += tail->pkt_len;
>
> - /* pkt_len is only set in the head */
> + /* nb_segs and pkt_len are only set in the head */
> + tail->nb_segs = 1;
> tail->pkt_len = tail->data_len;
>
> + __rte_mbuf_sanity_check(head, 1);
> +
> return 0;
> }
My understanding is that nb_segs and pkt_len are only valid
in head. For other packets in the chain nb_segs and pkt_len
can be anything.
next prev parent reply other threads:[~2017-11-16 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 14:05 [PATCH 2/2] mbuf: reset nb_segs of chained packet Ilya Matveychikov
2017-11-16 17:01 ` Stephen Hemminger [this message]
2017-11-16 19:15 ` Ilya Matveychikov
2017-12-01 16:37 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116090155.31419fe3@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=matvejchikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.