From: Lukas Wunner <lukas@wunner.de>
To: Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Rob Herring <rob.herring@linaro.org>,
Johan Hovold <johan@kernel.org>
Cc: Ronald Tschalaer <ronald@innovation.ch>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH] Bluetooth: hci_serdev: Init hci_uart proto_lock to avoid oops
Date: Fri, 17 Nov 2017 00:59:55 +0100 [thread overview]
Message-ID: <20171116235955.GA27601@wunner.de> (raw)
In-Reply-To: <f181189de5fd4c75da4708425df99e70abc6a127.1510875912.git.lukas@wunner.de>
On Fri, Nov 17, 2017 at 12:54:53AM +0100, Lukas Wunner wrote:
> John Stultz reports a boot time crash with the HiKey board (which uses
> hci_serdev) occurring in hci_uart_tx_wakeup(). That function is
> contained in hci_ldisc.c, but also called from the newer hci_serdev.c.
> It acquires the proto_lock in struct hci_uart and it turns out that we
> forgot to init the lock in the serdev code path, thus causing the crash.
>
> John bisected the crash to commit 67d2f8781b9f ("Bluetooth: hci_ldisc:
> Allow sleeping while proto locks are held"), but the issue was present
> before and the commit merely exposed it. (Perhaps by luck, the crash
> did not occur with rwlocks.)
>
> Init the proto_lock in the serdev code path to avoid the oops.
Apologies, I botched Gustavo Padovan's and Johan Hedberg's e-mail
address in the To: header, please fix up when replying.
Lukas
next prev parent reply other threads:[~2017-11-16 23:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 2:00 Boot crash @hci_uart_tx_wakeup+0x38/0x148 w/ Linus' HEAD? John Stultz
2017-11-16 20:58 ` John Stultz
2017-11-16 21:30 ` Lukas Wunner
2017-11-16 21:45 ` Lukas Wunner
2017-11-16 22:29 ` John Stultz
2017-11-16 23:54 ` [PATCH] Bluetooth: hci_serdev: Init hci_uart proto_lock to avoid oops Lukas Wunner
2017-11-16 23:59 ` Lukas Wunner [this message]
2017-11-17 6:07 ` Marcel Holtmann
2017-12-11 21:49 ` John Stultz
2018-01-02 20:39 ` John Stultz
2018-01-02 20:45 ` Marcel Holtmann
2018-02-01 5:50 ` Backport d73e17281665 to v4.15 stable Lukas Wunner
2018-02-01 6:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116235955.GA27601@wunner.de \
--to=lukas@wunner.de \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rob.herring@linaro.org \
--cc=ronald@innovation.ch \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.