From: Jason Gunthorpe <jgg@ziepe.ca>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Andrey Pronin <apronin@chromium.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tpm: Add explicit chip->ops locking for sysfs attributes.
Date: Thu, 16 Nov 2017 17:21:05 -0700 [thread overview]
Message-ID: <20171117002105.GD4276@ziepe.ca> (raw)
In-Reply-To: <1510868454-31912-1-git-send-email-linux@roeck-us.net>
On Thu, Nov 16, 2017 at 01:40:54PM -0800, Guenter Roeck wrote:
> Add explicit chip->ops locking for all sysfs attributes.
> This lets us support those attributes on tpm2 devices.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> v2: It makes sense to actually compile the code.
>
> drivers/char/tpm/tpm-chip.c | 4 --
> drivers/char/tpm/tpm-sysfs.c | 127 ++++++++++++++++++++++++++++++++-----------
> 2 files changed, 94 insertions(+), 37 deletions(-)
I haven't exhaustively checked this, but as the originator of the
comment, this looks broadly like the right approach to me.
Cheers,
Jason
prev parent reply other threads:[~2017-11-17 0:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 21:40 [PATCH v2] tpm: Add explicit chip->ops locking for sysfs attributes Guenter Roeck
2017-11-17 0:21 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117002105.GD4276@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=apronin@chromium.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.