From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Add a FIXME about FBC vs. fence. 90/270 degree rotation
Date: Fri, 17 Nov 2017 15:01:58 +0200 [thread overview]
Message-ID: <20171117130158.GG10981@intel.com> (raw)
In-Reply-To: <151086606356.26104.16918710940101165837@mail.alporthouse.com>
On Thu, Nov 16, 2017 at 09:01:03PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-11-16 19:14:50)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Currently we're pinning the fence for the rotated GTT view. That doesn't
> > acually make any sense since the fence is used only for the FBC GTT
> > tracking. For that we would want the fence for the normal GTT view
> > instead of the rotated view. Too lazy to fix this now so just add a
> > FIXME.
>
> The rotated view can't have a fence as its vma is not fenceable.
I see. Doesn't change the fact that it's broken though. I'll see about
rewording this, or maybe I'll even try to fix it.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-17 13:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 19:14 [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes Ville Syrjala
2017-11-16 19:14 ` [PATCH 2/5] drm/i915: Clean up fbc vs. plane checks Ville Syrjala
2017-11-16 19:14 ` [PATCH 3/5] drm/i915: Require fence only for FBC capable planes Ville Syrjala
2017-11-16 19:14 ` [PATCH 4/5] drm/i915: Add a FIXME about FBC vs. fence. 90/270 degree rotation Ville Syrjala
2017-11-16 21:01 ` Chris Wilson
2017-11-17 13:01 ` Ville Syrjälä [this message]
2017-11-16 19:14 ` [PATCH 5/5] drm/i915: Extract intel_plane_{pin, unpin}_fb() Ville Syrjala
2017-11-16 19:40 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes Patchwork
2017-11-16 20:49 ` [PATCH 1/5] " Rodrigo Vivi
2017-11-17 13:21 ` Ville Syrjälä
2017-11-17 17:29 ` Rodrigo Vivi
2017-11-22 14:42 ` Ville Syrjälä
2017-11-16 21:06 ` Chris Wilson
2017-11-17 13:17 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117130158.GG10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.