From: Stephen Hemminger <stephen@networkplumber.org>
To: Nishanth Devarajan <ndev2021@gmail.com>
Cc: netdev@vger.kernel.org, doucette@bu.edu, michel.machado@gmail.com
Subject: Re: [PATCH iproute2/net-next v3]tc: B.W limits can now be specified in %.
Date: Fri, 17 Nov 2017 13:12:58 -0800 [thread overview]
Message-ID: <20171117131258.194d2941@xeon-e3> (raw)
In-Reply-To: <20171117204335.GA17658@gmail.com>
On Sat, 18 Nov 2017 02:13:38 +0530
Nishanth Devarajan <ndev2021@gmail.com> wrote:
> diff --git a/tc/tc_util.h b/tc/tc_util.h
> index 583a21a..7b7420a 100644
> --- a/tc/tc_util.h
> +++ b/tc/tc_util.h
> @@ -24,14 +24,14 @@ struct qdisc_util {
> struct qdisc_util *next;
> const char *id;
> int (*parse_qopt)(struct qdisc_util *qu, int argc,
> - char **argv, struct nlmsghdr *n);
> + char **argv, struct nlmsghdr *n, char *dev);
One more nit...
Since parsing queue options should not modify the device name, that should
be const char *.
next prev parent reply other threads:[~2017-11-17 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 20:43 [PATCH iproute2/net-next v3]tc: B.W limits can now be specified in % Nishanth Devarajan
2017-11-17 20:54 ` Stephen Hemminger
2017-11-17 21:12 ` Stephen Hemminger [this message]
2017-11-24 19:25 ` Stephen Hemminger
2017-11-24 20:43 ` Nishanth Devarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117131258.194d2941@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=doucette@bu.edu \
--cc=michel.machado@gmail.com \
--cc=ndev2021@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.