From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [(resend) PATCH 1/2] drm/i915: Calculate vlv/chv intermediate watermarks correctly, v3. Date: Fri, 17 Nov 2017 15:31:20 +0200 Message-ID: <20171117133120.GJ10981@intel.com> References: <20171115163157.14372-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA6D86E07A for ; Fri, 17 Nov 2017 13:31:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171115163157.14372-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMTUsIDIwMTcgYXQgMDU6MzE6NTZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhlIHdhdGVybWFya3MgaXQgc2hvdWxkIGNhbGN1bGF0ZSBhZ2FpbnN0IGFy ZSB0aGUgb2xkIG9wdGltYWwgd2F0ZXJtYXJrcy4KPiBUaGUgY3VycmVudGx5IGFjdGl2ZSBjcnRj IHdhdGVybWFya3MgYXJlIHB1cmUgZmljdGlvbiwgYW5kIGFyZSBpbnZhbGlkIGluCj4gY2FzZSBv ZiBhIG5vbmJsb2NraW5nIG1vZGVzZXQsIHBhZ2UgZmxpcCBlbmFibGluZy9kaXNhYmxpbmcgcGxh bmVzIG9yIGFueQo+IG90aGVyIHJlYXNvbi4KPiAKPiBXaGVuIHRoZSBjcnRjIGlzIGRpc2FibGVk IG9yIGR1cmluZyBhIG1vZGVzZXQgdGhlIGludGVybWVkaWF0ZSB3YXRlcm1hcmtzCj4gZG9uJ3Qg bmVlZCB0byBiZSBwcm9ncmFtbWVkIHNlcGFyYXRlbHksIGFuZCBjb3VsZCBiZSBkaXJlY3RseSBh c3NpZ25lZAo+IHRvIHRoZSBvcHRpbWFsIHdhdGVybWFya3MuCj4gCj4gQ1hTUiBtdXN0IGFsd2F5 cyBiZSBkaXNhYmxlZCBpbiB0aGUgaW50ZXJtZWRpYXRlIGNhc2UgZm9yIG1vZGVzZXRzLCBlbHNl Cj4gd2UgZ2V0IGEgV0FSTiBmb3IgdmJsYW5rIHdhaXQgdGltZW91dC4KPiAKPiBBbHNvIHJlbmFt ZSBjcnRjX3N0YXRlIHRvIG5ld19jcnRjX3N0YXRlLCB0byBkaXN0aW5ndWlzaCBpdCBmcm9tIHRo ZSBvbGQgc3RhdGUuCj4gCj4gQ2hhbmdlcyBzaW5jZSB2MToKPiAtIFVzZSBpbnRlbF9hdG9taWNf Z2V0X29sZF9jcnRjX3N0YXRlLiAodmlsbGUpCj4gQ2hhbmdlcyBzaW5jZSB2MjoKPiAtIEFsd2F5 cyB1bnNldCBjeHNyIGR1cmluZyBtb2Rlc2V0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpJIHdhcyBnb2lu ZyB0byB0cnkgYW5kIGZpZ3VyZSBvdXQgaG93L2lmIHRoZXNlIGdldCByaWQgb2YgdGhlIHVuY2xh aW1lZApyZWcgd2FybnMsIGJ1dCBJIGRpZG4ndCBxdWl0ZSBnZXQgdGhhdCBmYXIuIEkgZGlkIHNw b3QgYSBmZXcgb3RoZXIKYnVnbGV0cyBpbiB0aGUgd20gY29kZSB0aG91Z2ggKEknbGwgc2VuZCBm aXhlcyBmb3IgdGhvc2UgYXQgc29tZSBwb2ludCkuCgpBbnl3YXlzLCB0aGVzZSBwYXRjaGVzIG1h a2Ugc2Vuc2UgdG8gbWUsIHNvIGZvciB0aGUgc2VyaWVzClJldmlld2VkLWJ5OiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDI0ICsrKysrKysrKysrKysrKysrKy0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCA4YzY5ZWM5ZWI2ZWUuLmY5MDRiZjczZGJkNiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC0yMDI2LDE2ICsyMDI2LDI3IEBAIHN0YXRp YyB2b2lkIHZsdl9hdG9taWNfdXBkYXRlX2ZpZm8oc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAq c3RhdGUsCj4gIAo+ICBzdGF0aWMgaW50IHZsdl9jb21wdXRlX2ludGVybWVkaWF0ZV93bShzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj LAo+IC0JCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICsJ CQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiAgewo+ IC0Jc3RydWN0IHZsdl93bV9zdGF0ZSAqaW50ZXJtZWRpYXRlID0gJmNydGNfc3RhdGUtPndtLnZs di5pbnRlcm1lZGlhdGU7Cj4gLQljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICpvcHRpbWFsID0g JmNydGNfc3RhdGUtPndtLnZsdi5vcHRpbWFsOwo+IC0JY29uc3Qgc3RydWN0IHZsdl93bV9zdGF0 ZSAqYWN0aXZlID0gJmNydGMtPndtLmFjdGl2ZS52bHY7Cj4gKwlzdHJ1Y3Qgdmx2X3dtX3N0YXRl ICppbnRlcm1lZGlhdGUgPSAmbmV3X2NydGNfc3RhdGUtPndtLnZsdi5pbnRlcm1lZGlhdGU7Cj4g Kwljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICpvcHRpbWFsID0gJm5ld19jcnRjX3N0YXRlLT53 bS52bHYub3B0aW1hbDsKPiArCXN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKmludGVsX3N0YXRl ID0KPiArCQl0b19pbnRlbF9hdG9taWNfc3RhdGUobmV3X2NydGNfc3RhdGUtPmJhc2Uuc3RhdGUp Owo+ICsJY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlID0KPiAr CQlpbnRlbF9hdG9taWNfZ2V0X29sZF9jcnRjX3N0YXRlKGludGVsX3N0YXRlLCBjcnRjKTsKPiAr CWNvbnN0IHN0cnVjdCB2bHZfd21fc3RhdGUgKmFjdGl2ZSA9ICZvbGRfY3J0Y19zdGF0ZS0+d20u dmx2Lm9wdGltYWw7Cj4gIAlpbnQgbGV2ZWw7Cj4gIAo+ICsJaWYgKCFuZXdfY3J0Y19zdGF0ZS0+ YmFzZS5hY3RpdmUgfHwgZHJtX2F0b21pY19jcnRjX25lZWRzX21vZGVzZXQoJm5ld19jcnRjX3N0 YXRlLT5iYXNlKSkgewo+ICsJCSppbnRlcm1lZGlhdGUgPSAqb3B0aW1hbDsKPiArCj4gKwkJaW50 ZXJtZWRpYXRlLT5jeHNyID0gZmFsc2U7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9Cj4gKwo+ICAJaW50 ZXJtZWRpYXRlLT5udW1fbGV2ZWxzID0gbWluKG9wdGltYWwtPm51bV9sZXZlbHMsIGFjdGl2ZS0+ bnVtX2xldmVscyk7Cj4gIAlpbnRlcm1lZGlhdGUtPmN4c3IgPSBvcHRpbWFsLT5jeHNyICYmIGFj dGl2ZS0+Y3hzciAmJgo+IC0JCSFjcnRjX3N0YXRlLT5kaXNhYmxlX2N4c3I7Cj4gKwkJIW5ld19j cnRjX3N0YXRlLT5kaXNhYmxlX2N4c3I7Cj4gIAo+ICAJZm9yIChsZXZlbCA9IDA7IGxldmVsIDwg aW50ZXJtZWRpYXRlLT5udW1fbGV2ZWxzOyBsZXZlbCsrKSB7Cj4gIAkJZW51bSBwbGFuZV9pZCBw bGFuZV9pZDsKPiBAQCAtMjA1NCwxMiArMjA2NSwxMyBAQCBzdGF0aWMgaW50IHZsdl9jb21wdXRl X2ludGVybWVkaWF0ZV93bShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAKPiAgCXZsdl9pbnZh bGlkYXRlX3dtcyhjcnRjLCBpbnRlcm1lZGlhdGUsIGxldmVsKTsKPiAgCj4gK291dDoKPiAgCS8q Cj4gIAkgKiBJZiBvdXIgaW50ZXJtZWRpYXRlIFdNIGFyZSBpZGVudGljYWwgdG8gdGhlIGZpbmFs IFdNLCB0aGVuIHdlIGNhbgo+ICAJICogb21pdCB0aGUgcG9zdC12YmxhbmsgcHJvZ3JhbW1pbmc7 IG9ubHkgdXBkYXRlIGlmIGl0J3MgZGlmZmVyZW50Lgo+ICAJICovCj4gIAlpZiAobWVtY21wKGlu dGVybWVkaWF0ZSwgb3B0aW1hbCwgc2l6ZW9mKCppbnRlcm1lZGlhdGUpKSAhPSAwKQo+IC0JCWNy dGNfc3RhdGUtPndtLm5lZWRfcG9zdHZibF91cGRhdGUgPSB0cnVlOwo+ICsJCW5ld19jcnRjX3N0 YXRlLT53bS5uZWVkX3Bvc3R2YmxfdXBkYXRlID0gdHJ1ZTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAg fQo+IC0tIAo+IDIuMTUuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==