From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
eblake@redhat.com, jsnow@redhat.com, famz@redhat.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch
Date: Fri, 17 Nov 2017 14:42:47 +0100 [thread overview]
Message-ID: <20171117134247.GE4795@localhost.localdomain> (raw)
In-Reply-To: <75e64a04-dfd4-2e66-dad6-95c8f012ad6f@openvz.org>
Am 17.11.2017 um 13:58 hat Denis V. Lunev geschrieben:
> On 11/17/2017 03:30 PM, Kevin Wolf wrote:
> > Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben:
> >> Snapshot-switch actually changes active state of disk so it should
> >> reflect on dirty bitmaps. Otherwise next incremental backup using
> >> these bitmaps will be invalid.
> >>
> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > We discussed this quite a while ago, and I'm still not convinced that
> > this approach makes sense.
> >
> > Can you give just one example of a use case where dirtying the whole
> > bitmap while loading a snapshot is the desired behaviour?
> >
> > I think the most useful behaviour would be something where the bitmaps
> > themselves are snapshotted, too. But for the time being, the easiest and
> > safest solution might just be to error out in any snapshot operations
> > if any bitmaps are in use.
> >
> The problem is that snapshotting of bitmaps will just provide wrong
> result.
Only if the user does the wrong thing. :-)
> Let us assume that we have bitmap named A.
>
> The user has started it and made full backup B.
> The user made snapshot S. At this moment bitmap A is saved as A' to bitmap.
> The user has made incremental backup B1. A is reset to 0.
> The user has made incremental backup B2. A is reset to 0 again.
>
> At this moment the user has reverted to snapshot S.
> What we need to make incremental backup at the moment?
The important point here is that the backup that you should make is not
incremental compared to B2, but to B (i.e. the last backup at the point
when the snapshot was made).
If your snapshot chain branches, your backups have to branch, too.
> The difference in between states B2 and S. This is __for sure__
> not A'. Thus saving of the bitmap at the moment is quite
> useless and we need to reset bitmap to full.
A' still contains the differences between B and the point when S was
created. So if you take a new incremental backup B'1 based on B, the
correct bitmap to use would be A'.
But I agree that this is complicated and probably easy to misuse, so
just erroring out is a serious option. And if we do this, at least we
don't set a bad solution in stone and can always add a better solution
if we can later think of one.
I just don't think that marking everything dirty is a good solution. It
forces the user to make a full backup, so we could just as well ask the
user to delete the bitmap before they load a snapshot.
Kevin
next prev parent reply other threads:[~2017-11-17 13:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 9:29 [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch Vladimir Sementsov-Ogievskiy
2017-10-27 21:23 ` Eric Blake
2017-11-02 20:55 ` John Snow
2017-11-14 14:58 ` Max Reitz
2017-11-17 12:30 ` Kevin Wolf
2017-11-17 12:58 ` Denis V. Lunev
2017-11-17 13:42 ` Kevin Wolf [this message]
2017-11-17 13:45 ` Denis V. Lunev
2017-11-17 15:01 ` Max Reitz
2017-11-17 18:15 ` John Snow
2017-11-17 18:25 ` Kevin Wolf
2017-11-17 20:40 ` John Snow
2017-11-20 9:51 ` Vladimir Sementsov-Ogievskiy
2017-11-20 12:00 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117134247.GE4795@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.