From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Andreas Kemnade <andreas@kemnade.info>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org,
Philippe Ombredanne <pombredanne@nexb.com>,
linux-usb@vger.kernel.org
Subject: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define
Date: Fri, 17 Nov 2017 15:19:39 +0100 [thread overview]
Message-ID: <20171117141939.GD17880@kroah.com> (raw)
There is no need to #define the license of the driver, just put it in
the MODULE_LICENSE() line directly as a text string.
This allows tools that check that the module license matches the source
code license to work properly, as there is no need to unwind the
unneeded dereference.
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andreas Kemnade <andreas@kemnade.info>
Cc: Johan Hovold <johan@kernel.org>
Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/usb/hso.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index d7a3379ea668..f40d1423cf46 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -76,7 +76,6 @@
#define MOD_AUTHOR "Option Wireless"
#define MOD_DESCRIPTION "USB High Speed Option driver"
-#define MOD_LICENSE "GPL"
#define HSO_MAX_NET_DEVICES 10
#define HSO__MAX_MTU 2048
@@ -3288,7 +3287,7 @@ module_exit(hso_exit);
MODULE_AUTHOR(MOD_AUTHOR);
MODULE_DESCRIPTION(MOD_DESCRIPTION);
-MODULE_LICENSE(MOD_LICENSE);
+MODULE_LICENSE("GPL");
/* change the debug level (eg: insmod hso.ko debug=0x04) */
MODULE_PARM_DESC(debug, "debug level mask [0x01 | 0x02 | 0x04 | 0x08 | 0x10]");
--
2.15.0
next reply other threads:[~2017-11-17 14:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 14:19 Greg Kroah-Hartman [this message]
2017-11-17 14:52 ` [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define Philippe Ombredanne
2017-11-17 14:52 ` Philippe Ombredanne
2017-11-18 1:37 ` David Miller
2017-11-18 1:37 ` David Miller
2017-11-22 17:05 ` [Cocci] " Joe Perches
2017-11-22 17:05 ` Joe Perches
2017-11-22 17:12 ` [Cocci] " Greg Kroah-Hartman
2017-11-22 17:12 ` Greg Kroah-Hartman
2017-11-23 23:30 ` [Cocci] " Joe Perches
2017-11-23 23:30 ` Joe Perches
2017-11-24 0:25 ` [Cocci] " Joe Perches
2017-11-24 0:25 ` Joe Perches
2017-11-22 17:21 ` [Cocci] [Outreachy kernel] " Julia Lawall
2017-11-22 17:21 ` Julia Lawall
2017-11-22 17:21 ` Julia Lawall
2017-11-22 21:20 ` [Cocci] " Julia Lawall
2017-11-22 21:20 ` Julia Lawall
2017-11-22 21:20 ` Julia Lawall
2017-11-23 6:22 ` [Cocci] " Greg Kroah-Hartman
2017-11-23 6:22 ` Greg Kroah-Hartman
2017-11-23 6:22 ` Greg Kroah-Hartman
2017-11-23 7:31 ` [Cocci] " Julia Lawall
2017-11-23 7:31 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117141939.GD17880@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas@kemnade.info \
--cc=davem@davemloft.net \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pombredanne@nexb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.