From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966797AbdKQWx7 (ORCPT ); Fri, 17 Nov 2017 17:53:59 -0500 Received: from ms.lwn.net ([45.79.88.28]:48920 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966782AbdKQWxy (ORCPT ); Fri, 17 Nov 2017 17:53:54 -0500 Date: Fri, 17 Nov 2017 15:53:53 -0700 From: Jonathan Corbet To: Greg KH Cc: Martin Kepplinger , akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] samples: replace outdated permission statement with SPDX identifiers Message-ID: <20171117155353.02950038@lwn.net> In-Reply-To: <20171116114110.GA5892@kroah.com> References: <20171115084541.GA23833@kroah.com> <20171115204411.10292-1-martink@posteo.de> <20171116114110.GA5892@kroah.com> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Nov 2017 12:41:10 +0100 Greg KH wrote: > > I'll fold this in, in the thread here. I guess this change is what Greg > > had in mind? Or would you prefer having including SPDX and removing > > permission statement seperately? > > I have been doing them in 2 steps, but only because the files I modified > were in different "chunks" (i.e. add missing SPDX identifiers to a bunch > of files in a directory, and then the second patch would remove the > license identifiers for all files in that directory). As that type of > patch flow doesn't make sense here, I think what you did was just fine. So I'll confess to being a little worried about removing the boilerplate: And it's important to notice that while adding a SPDX line should not really be controversial (as long as you get the license right, of course - Greg&co have the CSV files for everything, in case you want to check things you maintain), before removing the boiler-plate you really need to feel like you "own" the file. — Linus (https://lkml.org/lkml/2017/11/2/715) Are we sure that we're not going to get in trouble with the people who do "own" those files if we rip out the boilerplate? It would be good to have some clarity on when that can be done. Thanks, jon