From: Lukas Wunner <lukas@wunner.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Nicolai Hähnle" <nhaehnle@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [git pull] drm for v4.15
Date: Fri, 17 Nov 2017 18:19:09 +0100 [thread overview]
Message-ID: <20171117171909.GA15582@wunner.de> (raw)
In-Reply-To: <CA+55aFz4ZeXeu_bfiKGLJhqa8Z2zsvL9Xd+oBSYo-gsdLSSGfA@mail.gmail.com>
On Fri, Nov 17, 2017 at 08:57:53AM -0800, Linus Torvalds wrote:
> On Fri, Nov 17, 2017 at 4:51 AM, Nicolai Hähnle <nhaehnle@gmail.com> wrote:
> To see the effects of this, I picked something at random from one of
> those huge AMD header files.
>
> I swear. It was entirely at random, and the first thing I picked. Do this:
>
> git grep PCIE_UNCORR_ERR_MASK
Oh that looks familiar, it's the Uncorrectable Error Mask Register
(PCIe Base Spec r2.1 page 558). We already have those definitions
in the tree in include/uapi/linux/pci_regs.h:
git grep PCI_ERR_UNC_
> and tell me that there isn't any room for making these things smarter.
... or deduplicate them. :-)
Lukas
next prev parent reply other threads:[~2017-11-17 17:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 2:34 [git pull] drm for v4.15 Dave Airlie
2017-11-16 2:34 ` Dave Airlie
2017-11-16 4:59 ` Linus Torvalds
2017-11-16 4:59 ` Linus Torvalds
2017-11-16 13:57 ` Rob Clark
2017-11-16 13:57 ` Rob Clark
2017-11-16 17:17 ` Michel Dänzer
2017-11-16 17:17 ` Michel Dänzer
2017-11-16 20:57 ` Dave Airlie
2017-11-16 20:57 ` Dave Airlie
2017-11-16 21:05 ` Linus Torvalds
2017-11-16 21:05 ` Linus Torvalds
2017-11-17 12:51 ` Nicolai Hähnle
2017-11-17 12:51 ` Nicolai Hähnle
2017-11-17 16:57 ` Linus Torvalds
2017-11-17 16:57 ` Linus Torvalds
2017-11-17 17:19 ` Lukas Wunner [this message]
2017-11-17 17:24 ` Linus Torvalds
2017-11-17 17:24 ` Linus Torvalds
2017-11-17 18:14 ` Christian König
2017-11-17 18:14 ` Christian König
2017-11-17 18:55 ` Linus Torvalds
2017-11-17 18:55 ` Linus Torvalds
2017-11-17 19:18 ` Christian König
2017-11-17 19:18 ` Christian König
2017-11-18 10:49 ` Nicolai Hähnle
2017-11-18 10:49 ` Nicolai Hähnle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117171909.GA15582@wunner.de \
--to=lukas@wunner.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhaehnle@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.