From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ondrej Zary Subject: Re: Blank console but X11 works on MCP79 - old regression since 3.8 Date: Fri, 17 Nov 2017 20:25:14 +0100 Message-ID: <201711172025.15121.linux@rainbow-software.org> References: <201711171526.01053.linux@rainbow-software.org> <201711171833.52855.linux@rainbow-software.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Ilia Mirkin Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Ben Skeggs , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: nouveau.vger.kernel.org T24gRnJpZGF5IDE3IE5vdmVtYmVyIDIwMTcgMTg6NDE6MTcgSWxpYSBNaXJraW4gd3JvdGU6Cj4g T24gRnJpLCBOb3YgMTcsIDIwMTcgYXQgMTI6MzMgUE0sIE9uZHJlaiBaYXJ5Cj4KPiA8bGludXhA cmFpbmJvdy1zb2Z0d2FyZS5vcmc+IHdyb3RlOgo+ID4gQEAgLTQ4Myw4ICs0ODMsOCBAQAo+ID4g IG5vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNwOiAgICAwODYwOiAwMDAwMDAwMCAtPiAwMDAwMDUw MAo+ID4gIG5vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNwOiAgICAwODY0OiAwMDAwMDAwMAo+ID4g IG5vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNwOiAgICAwODY4OiAwMDAwMDAwMCAtPiAwNDAwMDUw MAo+ID4gLW5vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNwOiAgICAwODZjOiAwMDAwMDAwMCAtPiAw MDEwMDUwMAo+ID4gLW5vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNwOiAgICAwODcwOiAwMDAwZTkw MCAtPiAwMDAwMWUwMAo+ID4gK25vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNwOiAgICAwODZjOiAw MDAwMDAwMCAtPiAwMDEwMGEwMAo+ID4gK25vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNwOiAgICAw ODcwOiAwMDAwZTkwMCAtPiAwMDAwZTgwMAo+ID4gIG5vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNw OiAgICAwODc0OiAwMDAwMDAwMCAtPiBmZmZmMDAwMAo+ID4gIG5vdXZlYXUgMDAwMDowMjowMC4w OiBkaXNwOiAgICAwODc4OiAwMDAwMDAwMAo+ID4gIG5vdXZlYXUgMDAwMDowMjowMC4wOiBkaXNw OiAgICAwODgwOiAwNTAwMDAwMAo+ID4KPiA+IExvb2tzIGxpa2UgaXQncyB1c2luZyA4YnBwICgw eDFlMDApIGluIDMyTUIgY2FzZSBidXQgMTZicHAgKDB4ZTgwMCkgaW4KPiA+IDY0TUIgY2FzZS4g V2h5Pwo+ID4KPiA+IEkgZ2V0IGJsYW5rIHNjcmVlbiBldmVuIHdpdGggNjRNQiB3aXRoIHZpZGVv PTEyODB4MTAyNC04IGtlcm5lbAo+ID4gcGFyYW1ldGVyLiBDb25zb2xlIHdvcmtzIHdpdGggdmlk ZW89MTI4MHgxMDI0LTE2IGV2ZW4gd2l0aCAzMk1CIHN0b2xlbgo+ID4gbWVtb3J5Lgo+ID4KPiA+ IENvbmNsdXNpb25zOiA4LWJpdCBzdXBwb3J0IGlzIGJyb2tlbiBhbmQgYnBwIHJlZHVjdGlvbiBp cyB3ZWlyZC4KPgo+IE9LLCB3ZWxsIHRoYXQgbWFrZXMgYSAqdG9uKiBvZiBzZW5zZSAoOGJwcCBi ZWluZyBicm9rZW4pLgo+Cj4gSSB0aGluayB0aGUgaWRlYSBvZiBicHAgcmVkdWN0aW9uIGlzIHRo YXQgd2hlbiB5b3UncmUgb24geW91ciBzaGlueQo+IG5ldyBSaXZhIFROVCB3aXRoIDE2TUIgb2Yg VlJBTSwgeW91IGRvbid0IHdhbnQgdG8gZ28gY3JhenkgYWxsb2NhdGluZwo+IGFsbCB0aGF0IHRv IGEgcGlubmVkIGZiY29uIC0gYWxtb3N0IGhhbGYgb2YgdGhhdCB3b3VsZCBnbyB0byBhIHNpbmds ZQo+IDMyYnBwIDE2MDB4MTIwMCBidWZmZXIsIG1vcmUgZm9yIDE5MjB4MTIwMC4gWW91IHdhbnQg dG8gYmUgYWJsZSB0bwo+IGhhdmUgYXQgbGVhc3QgYSBmZXcgZmItc2l6ZWQgYnVmZmVycyBmb3Ig YmFja2J1ZmZlciByZW5kZXJpbmcsIGV0Yy4KPgo+IFRoZSBzcGVjaWZpYyBsaW1pdHMgY291bGQg cHJvYmFibHkgdXNlIHR3ZWFraW5nIC0gSSB0aGluayB0aGV5IG9ubHkKPiBjb25zaWRlciBWUkFN IHNpemUsIG5vdCB0aGUgZmIgc2l6ZS4KPgo+IEkgZ3Vlc3MgOGJwcCB3b3JrZWQgcHJpb3IgdG8g dGhlIGNoYW5nZSB5b3UgYmlzZWN0ZWQgdGhvdWdoLCBzbyB3ZQo+IHNob3VsZCBmaWd1cmUgb3V0 IHdoYXQgd2UgZGlkIHdyb25nIGluIHRoZSBuZXcgY29kZS4KClllcywgYm9vdGVkIDMuNyAobGFz dCB3b3JraW5nIGtlcm5lbCkgYW5kIGl0J3MgcnVubmluZyBpbiA4YnBwLgoKSSBndWVzcyB0aGF0 IG52NTBfaGVhZF9nYW1tYV9zZXQoKSBpcyBtaXNzaW5nIHNvbWV0aGluZyBsaWtlIHRoaXMgKGZy b20gCm52X2NydGNfZ2FtbWFfc2V0KCkpOgogICAgICAgIC8qIFdlIG5lZWQgdG8ga25vdyB0aGUg ZGVwdGggYmVmb3JlIHdlIHVwbG9hZCwgYnV0IGl0J3MgcG9zc2libGUgdG8KICAgICAgICAgKiBn ZXQgY2FsbGVkIGJlZm9yZSBhIGZyYW1lYnVmZmVyIGlzIGJvdW5kLiAgSWYgdGhpcyBpcyB0aGUg Y2FzZSwKICAgICAgICAgKiBtYXJrIHRoZSBsdXQgdmFsdWVzIGFzIGRpcnR5IGJ5IHNldHRpbmcg ZGVwdGg9PTAsIGFuZCBpdCdsbCBiZQogICAgICAgICAqIHVwbG9hZGVkIG9uIHRoZSBmaXJzdCBt b2RlX3NldF9iYXNlKCkKICAgICAgICAgKi8KICAgICAgICBpZiAoIW52X2NydGMtPmJhc2UucHJp bWFyeS0+ZmIpIHsKICAgICAgICAgICAgICAgIG52X2NydGMtPmx1dC5kZXB0aCA9IDA7CiAgICAg ICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICB9CgpUaGF0J3MgZWFzeSB0byBhZGQgYnV0IHRo ZXJlJ3Mgbm8gbW9kZV9zZXRfYmFzZSgpIGZvciBudjUwIHNvIHRoZXJlJ3Mgbm8gcGxhY2UgCnRv IGFkZCBjb2RlIGxpa2UgdGhpczoKICAgICAgICBpZiAobnZfY3J0Yy0+bHV0LmRlcHRoICE9IGRy bV9mYi0+Zm9ybWF0LT5kZXB0aCkgewogICAgICAgICAgICAgICAgbnZfY3J0Yy0+bHV0LmRlcHRo ID0gZHJtX2ZiLT5mb3JtYXQtPmRlcHRoOwogICAgICAgICAgICAgICAgbnZfY3J0Y19nYW1tYV9s b2FkKGNydGMpOwogICAgICAgIH0KCi0tIApPbmRyZWogWmFyeQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxpbmcgbGlzdApOb3V2ZWF1 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL25vdXZlYXUK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753505AbdKQT1B (ORCPT ); Fri, 17 Nov 2017 14:27:01 -0500 Received: from smtp-1b.atlantis.sk ([80.94.52.26]:53755 "EHLO smtp-1b.atlantis.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757171AbdKQT01 (ORCPT ); Fri, 17 Nov 2017 14:26:27 -0500 From: Ondrej Zary To: Ilia Mirkin Subject: Re: Blank console but X11 works on MCP79 - old regression since 3.8 Date: Fri, 17 Nov 2017 20:25:14 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: Ben Skeggs , "nouveau@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" References: <201711171526.01053.linux@rainbow-software.org> <201711171833.52855.linux@rainbow-software.org> In-Reply-To: X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201711172025.15121.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 17 November 2017 18:41:17 Ilia Mirkin wrote: > On Fri, Nov 17, 2017 at 12:33 PM, Ondrej Zary > > wrote: > > @@ -483,8 +483,8 @@ > > nouveau 0000:02:00.0: disp: 0860: 00000000 -> 00000500 > > nouveau 0000:02:00.0: disp: 0864: 00000000 > > nouveau 0000:02:00.0: disp: 0868: 00000000 -> 04000500 > > -nouveau 0000:02:00.0: disp: 086c: 00000000 -> 00100500 > > -nouveau 0000:02:00.0: disp: 0870: 0000e900 -> 00001e00 > > +nouveau 0000:02:00.0: disp: 086c: 00000000 -> 00100a00 > > +nouveau 0000:02:00.0: disp: 0870: 0000e900 -> 0000e800 > > nouveau 0000:02:00.0: disp: 0874: 00000000 -> ffff0000 > > nouveau 0000:02:00.0: disp: 0878: 00000000 > > nouveau 0000:02:00.0: disp: 0880: 05000000 > > > > Looks like it's using 8bpp (0x1e00) in 32MB case but 16bpp (0xe800) in > > 64MB case. Why? > > > > I get blank screen even with 64MB with video=1280x1024-8 kernel > > parameter. Console works with video=1280x1024-16 even with 32MB stolen > > memory. > > > > Conclusions: 8-bit support is broken and bpp reduction is weird. > > OK, well that makes a *ton* of sense (8bpp being broken). > > I think the idea of bpp reduction is that when you're on your shiny > new Riva TNT with 16MB of VRAM, you don't want to go crazy allocating > all that to a pinned fbcon - almost half of that would go to a single > 32bpp 1600x1200 buffer, more for 1920x1200. You want to be able to > have at least a few fb-sized buffers for backbuffer rendering, etc. > > The specific limits could probably use tweaking - I think they only > consider VRAM size, not the fb size. > > I guess 8bpp worked prior to the change you bisected though, so we > should figure out what we did wrong in the new code. Yes, booted 3.7 (last working kernel) and it's running in 8bpp. I guess that nv50_head_gamma_set() is missing something like this (from nv_crtc_gamma_set()): /* We need to know the depth before we upload, but it's possible to * get called before a framebuffer is bound. If this is the case, * mark the lut values as dirty by setting depth==0, and it'll be * uploaded on the first mode_set_base() */ if (!nv_crtc->base.primary->fb) { nv_crtc->lut.depth = 0; return 0; } That's easy to add but there's no mode_set_base() for nv50 so there's no place to add code like this: if (nv_crtc->lut.depth != drm_fb->format->depth) { nv_crtc->lut.depth = drm_fb->format->depth; nv_crtc_gamma_load(crtc); } -- Ondrej Zary