All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: remove stale comment
Date: Mon, 20 Nov 2017 17:33:50 +0000	[thread overview]
Message-ID: <20171120173350.GJ32488@arm.com> (raw)
In-Reply-To: <20171120172629.24006-1-mark.rutland@arm.com>

On Mon, Nov 20, 2017 at 05:26:29PM +0000, Mark Rutland wrote:
> Since commit:
> 
>   155433cb365ee466 ("arm64: cache: Remove support for ASID-tagged VIVT I-caches")
> 
> ... the ASID rollover code no longer performs I-cache maintenance, yet a
> leftover comment says it does. The comment doesn't say anything that
> can't be inferred from the next line, so let's remove it entirely.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> ---
>  arch/arm64/mm/context.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> index ab9f5f0fb2c7..b48ec1e18184 100644
> --- a/arch/arm64/mm/context.c
> +++ b/arch/arm64/mm/context.c
> @@ -117,7 +117,6 @@ static void flush_context(unsigned int cpu)
>  		per_cpu(reserved_asids, i) = asid;
>  	}
>  
> -	/* Queue a TLB invalidate and flush the I-cache if necessary. */
>  	cpumask_setall(&tlb_flush_pending);

Given that we don't normally do TLB invalidation by setting a flag, I'd
be inclined to say something like

	/*
	 * Queue a TLB invalidation for each CPU to perform on next
	 * context-switch.
	 */

Also, if you're bored, there's a comment in asm/cacheflush.h talking about
ASID-tagged I-cache too.

Will

      reply	other threads:[~2017-11-20 17:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 17:26 [PATCH] arm64: mm: remove stale comment Mark Rutland
2017-11-20 17:33 ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171120173350.GJ32488@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.