From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v5 08/11] intel_sgx: in-kernel launch enclave Date: Tue, 21 Nov 2017 00:25:35 +0200 Message-ID: <20171120222535.7yqibz2rxltwvip7@linux.intel.com> References: <20171113194528.28557-1-jarkko.sakkinen@linux.intel.com> <20171113194528.28557-9-jarkko.sakkinen@linux.intel.com> <20171115115006.p2wkvfuojwgg26br@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:22977 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbdKTWZk (ORCPT ); Mon, 20 Nov 2017 17:25:40 -0500 Content-Disposition: inline In-Reply-To: <20171115115006.p2wkvfuojwgg26br@hirez.programming.kicks-ass.net> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner On Wed, Nov 15, 2017 at 12:50:06PM +0100, Peter Zijlstra wrote: > On Mon, Nov 13, 2017 at 09:45:25PM +0200, Jarkko Sakkinen wrote: > > TinyCrypt (https://github.com/01org/tinycrypt) is used as AES > > implementation, which is not timing resistant. Eventually this needs to > > be replaced with AES-NI based implementation that could be either > > > - re-use existing AES-NI code in the kernel > > This. That is an absolute must. We're not going to merge custom AES > implementations. I'll post v6 update without update to this in order to get otherwise improved version out and work on it for v7. My initial idea to sort this out would be to try to compile arch/x86/crypto/aesni-intel_asm.S as part of the enclave binary and use it to run AES-256. /Jarkko