From: Steven Rostedt <rostedt@goodmis.org>
To: joe.korty@concurrent-rt.com
Cc: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 4.4.86-rt99: fix sync breakage between nr_cpus_allowed and cpus_allowed
Date: Mon, 20 Nov 2017 23:02:07 -0500 [thread overview]
Message-ID: <20171120230207.19a4bc14@vmware.local.home> (raw)
In-Reply-To: <20171120163040.GA25993@zipoli.concurrent-rt.com>
On Mon, 20 Nov 2017 11:30:40 -0500
joe.korty@concurrent-rt.com wrote:
> Hi Steve,
> A quick perusal of 4.11.12-rt16 shows that it has an
> entirely new version of migrate_disable which to me appears
> correct.
>
> In that new implementation, migrate_enable() recalculates
> p->nr_cpus_allowed when it switches the task back to
> using p->cpus_mask. This brings the two back into sync
> if anything had happened to get them out of sync while
> migration was disabled (as would happen on an affinity
> change during that disable period).
>
> 4.9.47-rt37 has the old implementation and it appears to
> have same bug as 4.4-rt though I have yet to test 4.9-rt.
>
> The fix in these older versions could take one of two
> forms: either we recalculate p->nr_cpus_allowed when
> migrate_enable goes back to using p->cpus_allowed,
> as the 4.11-rt version does, or the one place where we
> allow p->nr_cpus_allowed to diverge from p->cpus_allowed
> be fixed. The patch I submitted earlier takes this second
> approach.
>
Ideally, I would like to stay close to what upstream -rt does. Would
you be able to backport the 4.11-rt patch?
I'm currently working on releasing 4.9-rt and 4.4-rt with the latest
backports. I could easily add this one too.
-- Steve
next prev parent reply other threads:[~2017-11-21 4:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 19:25 [PATCH] 4.4.86-rt99: fix sync breakage between nr_cpus_allowed and cpus_allowed joe.korty
2017-11-17 22:48 ` Steven Rostedt
2017-11-20 16:30 ` joe.korty
2017-11-21 4:02 ` Steven Rostedt [this message]
2017-11-21 4:57 ` Steven Rostedt
2017-11-21 14:33 ` joe.korty
2017-11-21 15:33 ` joe.korty
2017-11-29 0:22 ` Steven Rostedt
2017-11-29 14:24 ` joe.korty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120230207.19a4bc14@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=joe.korty@concurrent-rt.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.