All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	James Smart <james.smart@broadcom.com>
Subject: [PATCH v3 08/17] lpfc: Fix display for debugfs queInfo
Date: Mon, 20 Nov 2017 16:00:35 -0800	[thread overview]
Message-ID: <20171121000044.27702-9-jsmart2021@gmail.com> (raw)
In-Reply-To: <20171121000044.27702-1-jsmart2021@gmail.com>

Display for lpfc/fnX/iDiag/queInfo isn't formatted perfectly.
Corrected the format strings for the queue info debug messages.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
---
 drivers/scsi/lpfc/lpfc_debugfs.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index 2bf5ad3b1512..4df5a21bd93b 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -3246,7 +3246,7 @@ __lpfc_idiag_print_eq(struct lpfc_queue *qp, char *eqtype,
 
 	len += snprintf(pbuffer + len, LPFC_QUE_INFO_GET_BUF_SIZE - len,
 			"\n%s EQ info: EQ-STAT[max:x%x noE:x%x "
-			"bs:x%x proc:x%llx eqd %d]\n",
+			"cqe_proc:x%x eqe_proc:x%llx eqd %d]\n",
 			eqtype, qp->q_cnt_1, qp->q_cnt_2, qp->q_cnt_3,
 			(unsigned long long)qp->q_cnt_4, qp->q_mode);
 	len += snprintf(pbuffer + len, LPFC_QUE_INFO_GET_BUF_SIZE - len,
@@ -3366,6 +3366,12 @@ lpfc_idiag_queinfo_read(struct file *file, char __user *buf, size_t nbytes,
 		if (len >= max_cnt)
 			goto too_big;
 
+		qp = phba->sli4_hba.hdr_rq;
+		len = __lpfc_idiag_print_rqpair(qp, phba->sli4_hba.dat_rq,
+						"ELS RQpair", pbuffer, len);
+		if (len >= max_cnt)
+			goto too_big;
+
 		/* Slow-path NVME LS response CQ */
 		qp = phba->sli4_hba.nvmels_cq;
 		len = __lpfc_idiag_print_cq(qp, "NVME LS",
@@ -3383,12 +3389,6 @@ lpfc_idiag_queinfo_read(struct file *file, char __user *buf, size_t nbytes,
 		if (len >= max_cnt)
 			goto too_big;
 
-		qp = phba->sli4_hba.hdr_rq;
-		len = __lpfc_idiag_print_rqpair(qp, phba->sli4_hba.dat_rq,
-				"RQpair", pbuffer, len);
-		if (len >= max_cnt)
-			goto too_big;
-
 		goto out;
 	}
 
-- 
2.13.1

  parent reply	other threads:[~2017-11-21  0:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21  0:00 [PATCH v3 00/17] lpfc updates for 11.4.0.5 James Smart
2017-11-21  0:00 ` [PATCH v3 01/17] lpfc: FLOGI failures are reported when connected to a private loop James Smart
2017-11-21  0:00 ` [PATCH v3 02/17] lpfc: Expand WQE capability of every NVME hardware queue James Smart
2017-11-21  0:00 ` [PATCH v3 03/17] lpfc: Handle XRI_ABORTED_CQE in soft IRQ James Smart
2017-11-21  0:00 ` [PATCH v3 04/17] lpfc: Fix crash after bad bar setup on driver attachment James Smart
2017-11-21  0:00 ` [PATCH v3 05/17] lpfc: Fix NVME LS abort_xri James Smart
2017-11-21  0:00 ` [PATCH v3 06/17] lpfc: Raise maximum NVME sg list size for 256 elements James Smart
2017-11-21  0:00 ` [PATCH v3 07/17] lpfc: Driver fails to detect direct attach storage array James Smart
2017-11-21  0:00 ` James Smart [this message]
2017-11-21  0:00 ` [PATCH v3 09/17] lpfc: Adjust default value of lpfc_nvmet_mrq James Smart
2017-11-21  0:00 ` [PATCH v3 10/17] lpfc: Fix ndlp ref count for pt2pt mode issue RSCN James Smart
2017-11-21  0:00 ` [PATCH v3 11/17] lpfc: Linux LPFC driver does not process all RSCNs James Smart
2017-11-21  8:12   ` Hannes Reinecke
2017-11-21  0:00 ` [PATCH v3 12/17] lpfc: correct port registrations with nvme_fc James Smart
2017-11-21  0:00 ` [PATCH v3 13/17] lpfc: Correct driver deregistrations with host nvme transport James Smart
2017-11-21  8:13   ` Hannes Reinecke
2017-11-21  0:00 ` [PATCH v3 14/17] lpfc: Fix crash during driver unload with running nvme traffic James Smart
2017-11-21  0:00 ` [PATCH v3 15/17] lpfc: Fix driver handling of nvme resources during unload James Smart
2017-11-21  0:00 ` [PATCH v3 16/17] lpfc: small sg cnt cleanup James Smart
2017-11-21  0:00 ` [PATCH v3 17/17] lpfc: update driver version to 11.4.0.5 James Smart
2017-11-22  3:56 ` [PATCH v3 00/17] lpfc updates for 11.4.0.5 Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171121000044.27702-9-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=james.smart@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.