From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Julia Cartwright <julia@ni.com>,
Daniel Wagner <daniel.wagner@siemens.com>,
tom.zanussi@linux.intel.com, Alex Shi <alex.shi@linaro.org>,
rt-stable@vger.kernel.org
Subject: [PATCH RT 2/8] rtmutex: Make lock_killable work
Date: Tue, 21 Nov 2017 11:06:56 -0500 [thread overview]
Message-ID: <20171121160705.955266215@goodmis.org> (raw)
In-Reply-To: 20171121160654.493640386@goodmis.org
[-- Attachment #1: 0002-rtmutex-Make-lock_killable-work.patch --]
[-- Type: text/plain, Size: 1439 bytes --]
4.4.97-rt111-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Thomas Gleixner <tglx@linutronix.de>
Locking an rt mutex killable does not work because signal handling is
restricted to TASK_INTERRUPTIBLE.
Use signal_pending_state() unconditionaly.
Cc: rt-stable@vger.kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/locking/rtmutex.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index 0e9a6260441d..552dc6dd3a79 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -1672,18 +1672,13 @@ __rt_mutex_slowlock(struct rt_mutex *lock, int state,
if (try_to_take_rt_mutex(lock, current, waiter))
break;
- /*
- * TASK_INTERRUPTIBLE checks for signals and
- * timeout. Ignored otherwise.
- */
- if (unlikely(state == TASK_INTERRUPTIBLE)) {
- /* Signal pending? */
- if (signal_pending(current))
- ret = -EINTR;
- if (timeout && !timeout->task)
- ret = -ETIMEDOUT;
- if (ret)
- break;
+ if (timeout && !timeout->task) {
+ ret = -ETIMEDOUT;
+ break;
+ }
+ if (signal_pending_state(state, current)) {
+ ret = -EINTR;
+ break;
}
if (ww_ctx && ww_ctx->acquired > 0) {
--
2.13.2
next prev parent reply other threads:[~2017-11-21 16:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 16:06 [PATCH RT 0/8] Linux 4.4.97-rt111-rc1 Steven Rostedt
2017-11-21 16:06 ` [PATCH RT 1/8] timer/hrtimer: check properly for a running timer Steven Rostedt
2017-11-21 16:06 ` Steven Rostedt [this message]
2017-11-21 16:06 ` [PATCH RT 3/8] random: avoid preempt_disable()ed section Steven Rostedt
2017-11-21 16:06 ` [PATCH RT 4/8] sched: Prevent task state corruption by spurious lock wakeup Steven Rostedt
2017-11-21 16:06 ` [PATCH RT 5/8] sched: Remove TASK_ALL Steven Rostedt
2017-11-21 16:19 ` Peter Zijlstra
2017-11-21 16:27 ` Steven Rostedt
2017-11-21 17:26 ` Thomas Gleixner
2017-11-21 16:07 ` [PATCH RT 6/8] sched/migrate disable: handle updated task-mask mg-dis section Steven Rostedt
2017-11-21 16:07 ` [PATCH RT 8/8] Linux 4.4.97-rt111-rc1 Steven Rostedt
[not found] ` <20171121160706.703915626@goodmis.org>
2017-11-21 16:20 ` [PATCH RT 7/8] kernel/locking: use an exclusive wait_q for sleepers Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121160705.955266215@goodmis.org \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=alex.shi@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=daniel.wagner@siemens.com \
--cc=jkacur@redhat.com \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rt-stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.