From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbdKUQzl (ORCPT ); Tue, 21 Nov 2017 11:55:41 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:52728 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbdKUQzk (ORCPT ); Tue, 21 Nov 2017 11:55:40 -0500 Date: Tue, 21 Nov 2017 17:55:41 +0100 From: Greg Kroah-Hartman To: Mark Rutland Cc: Catalin Marinas , Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Will Deacon Subject: Re: [PATCH 4.4 07/40] arm64: ensure __dump_instr() checks addr_limit Message-ID: <20171121165541.GA23027@kroah.com> References: <20171120105309.73i2sllqq5lfjlba@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171120105309.73i2sllqq5lfjlba@lakrids.cambridge.arm.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 11:26:20AM +0000, Mark Rutland wrote: > On Sun, Nov 19, 2017 at 11:29:35AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Nov 14, 2017 at 04:18:23PM +0000, Mark Rutland wrote: > > > I agree that we need both patches. On its own (in the absence of PAN/UAO), > > > 57f4959bad0a154a wouldn't have any effect, but it is critical to ensure that we > > > can dump kernel instructions when we intend to, with 7a7003b1da010d2b > > > backported. > > > > > > Backporting 57f4959bad0a154a as a prerequisite makes sense to me. > > > > But that is a "new feature", are you sure about this? > > Sorry, I copied the wrong commit ID when replying. I meant to say that > we should backport commit: > > c5cea06be060f38e ("arm64: fix dump_instr when PAN and UAO are in use") > > ... which on its own does nothing, but will prevent 7a7003b1da010d2b > from breaking kernel dumps. > > We should *not* backport commit: > > 57f4959bad0a154a ("arm64: kernel: Add support for User Access Override") > > > So, just apply that one patch and we are all ok? Nothing else? > > Just apply c5cea06be060f38e as a prerequisite for 7a7003b1da010d2b, and > I think we're good. I'm not aware of anything else we need. > > > confused, > > Sorry about that. Hopefully the above clarified things? Yes, it did, thanks, I think I've queued up the right patches now, if not, please let me know :) greg k-h