From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl
Date: Tue, 21 Nov 2017 19:09:18 +0200 [thread overview]
Message-ID: <20171121190647-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20171121175812.6f922e2e@redhat.com>
On Tue, Nov 21, 2017 at 05:58:12PM +0100, Igor Mammedov wrote:
> anyways, if you prefer having mixed endianness here, I won't mind much,
> as impact of test case is much smaller so we'll see down the road
> if it became any better.
I agree here.
> (as far as we continue going in direction
> of using host byteorder within main qemu acpi code, which we were
> doing by gradually converting acpi structures to build_append_foo API)
So APIs are absolutely a good alternative. If we get rid of
packed structures in main qemu code, we could convert tests
to whatever makes sense for tests.
--
MST
prev parent reply other threads:[~2017-11-21 17:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 12:17 [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl Thomas Huth
2017-11-20 16:55 ` Igor Mammedov
2017-11-20 20:00 ` Thomas Huth
2017-11-20 20:32 ` Michael S. Tsirkin
2017-11-21 13:26 ` Igor Mammedov
2017-11-21 14:47 ` Michael S. Tsirkin
2017-11-21 15:58 ` Igor Mammedov
2017-11-21 16:02 ` Michael S. Tsirkin
2017-11-21 16:22 ` Igor Mammedov
2017-11-21 16:31 ` Michael S. Tsirkin
2017-11-21 16:58 ` Igor Mammedov
2017-11-21 17:09 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121190647-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.