From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jin Yao <yao.jin@linux.intel.com>,
acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, kan.liang@intel.com,
yao.jin@intel.com
Subject: Re: [PATCH v1 5/9] perf util: Remove a set of shadow stats static variables
Date: Tue, 21 Nov 2017 22:19:50 +0100 [thread overview]
Message-ID: <20171121211950.GA28582@krava> (raw)
In-Reply-To: <20171121180350.GJ28112@tassilo.jf.intel.com>
On Tue, Nov 21, 2017 at 10:03:50AM -0800, Andi Kleen wrote:
> > all this is about switching from array to rb_list for the --per-thread case,
> > which can be considered as a special use case.. how much do we suffer in
> > performance with new code? how about the "perf stat -I 100", would it scale
> > ok for extreme cases (many events in -e or -dddd..)
>
> rbtrees scale by log N, with N being the entries in the tree.
>
> Even in extreme cases, let's say 10000 events and 1000 cpus it would
> need only 8 memory accesses and comparisons for each look up.
> Even if we assume cache misses for all of the memory lookups,
> at ~200ns per cache miss it's still only 1us per event, which
> is negligible.
>
> In practice not all memory accesses will be misses because
> the upper levels of the tree are almost certainly cached
> from earlier accesses.
sounds good, thanks
jirka
next prev parent reply other threads:[~2017-11-21 21:19 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 14:43 [PATCH v1 0/9] perf stat: Enable '--per-thread' on all threads Jin Yao
2017-11-20 9:26 ` Jiri Olsa
2017-11-20 12:15 ` Jin, Yao
2017-11-20 12:29 ` Jiri Olsa
2017-11-20 15:50 ` Andi Kleen
2017-11-20 14:43 ` [PATCH v1 1/9] perf util: Create rblist__reset() function Jin Yao
2017-11-20 14:43 ` [PATCH v1 2/9] perf util: Define a structure for runtime shadow metrics stats Jin Yao
2017-11-21 15:18 ` Jiri Olsa
2017-11-22 3:11 ` Jin, Yao
2017-11-20 14:43 ` [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats Jin Yao
2017-11-21 15:17 ` Jiri Olsa
2017-11-22 1:29 ` Jin, Yao
2017-11-22 8:30 ` Jiri Olsa
2017-11-21 15:17 ` Jiri Olsa
2017-11-22 1:35 ` Jin, Yao
2017-11-21 15:17 ` Jiri Olsa
2017-11-22 1:45 ` Jin, Yao
2017-11-21 15:17 ` Jiri Olsa
2017-11-22 2:11 ` Jin, Yao
2017-11-21 15:17 ` Jiri Olsa
2017-11-22 2:19 ` Jin, Yao
2017-11-21 15:17 ` Jiri Olsa
2017-11-22 2:20 ` Jin, Yao
2017-11-22 6:31 ` Ravi Bangoria
2017-11-22 6:57 ` Jin, Yao
2017-11-22 8:32 ` Jiri Olsa
2017-11-22 12:03 ` Jin, Yao
2017-11-20 14:43 ` [PATCH v1 4/9] perf util: Update and print " Jin Yao
2017-11-21 15:17 ` Jiri Olsa
2017-11-22 2:42 ` Jin, Yao
2017-11-21 15:18 ` Jiri Olsa
2017-11-22 3:10 ` Jin, Yao
2017-11-22 8:37 ` Jiri Olsa
2017-11-22 12:06 ` Jin, Yao
2017-11-20 14:43 ` [PATCH v1 5/9] perf util: Remove a set of shadow stats static variables Jin Yao
2017-11-21 15:17 ` Jiri Olsa
2017-11-21 18:03 ` Andi Kleen
2017-11-21 21:19 ` Jiri Olsa [this message]
2017-11-20 14:43 ` [PATCH v1 6/9] perf stat: Allocate shadow stats buffer for threads Jin Yao
2017-11-20 14:43 ` [PATCH v1 7/9] perf util: Reuse thread_map__new_by_uid to enumerate threads from /proc Jin Yao
2017-11-20 14:43 ` [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation Jin Yao
2017-11-21 15:18 ` Jiri Olsa
2017-11-22 3:42 ` Jin, Yao
2017-11-22 8:35 ` Jiri Olsa
2017-11-21 15:18 ` Jiri Olsa
2017-11-22 5:34 ` Jin, Yao
2017-11-21 15:18 ` Jiri Olsa
2017-11-22 5:38 ` Jin, Yao
2017-11-20 14:43 ` [PATCH v1 9/9] perf stat: Resort '--per-thread' result Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121211950.GA28582@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.