From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot() Date: Wed, 22 Nov 2017 17:58:29 +0100 Message-ID: <20171122165829.GA2651@kroah.com> References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-30-git-send-email-okaya@codeaurora.org> <20171122075345.GC26583@kroah.com> <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> <20171122164546.GB30812@kroah.com> <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39070 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbdKVQ60 (ORCPT ); Wed, 22 Nov 2017 11:58:26 -0500 Content-Disposition: inline In-Reply-To: <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sinan Kaya Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Philippe Ombredanne , Kate Stewart , Thomas Gleixner , open list On Wed, Nov 22, 2017 at 11:50:53AM -0500, Sinan Kaya wrote: > On 11/22/2017 11:45 AM, Greg Kroah-Hartman wrote: > >> Funny thing is nobody is calling this function. Maybe, I should just kill it > >> instead. > > Yes, delete it. Why doesn't the build warn about it not being used? > > > > OK. Because it is in a header file that nobody includes. Even better, just delete the whole file! :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Wed, 22 Nov 2017 17:58:29 +0100 From: Greg Kroah-Hartman To: Sinan Kaya Subject: Re: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot() Message-ID: <20171122165829.GA2651@kroah.com> References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-30-git-send-email-okaya@codeaurora.org> <20171122075345.GC26583@kroah.com> <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> <20171122164546.GB30812@kroah.com> <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> MIME-Version: 1.0 In-Reply-To: <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , linux-pci@vger.kernel.org, timur@codeaurora.org, open list , Philippe Ombredanne , linux-arm-msm@vger.kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Wed, Nov 22, 2017 at 11:50:53AM -0500, Sinan Kaya wrote: > On 11/22/2017 11:45 AM, Greg Kroah-Hartman wrote: > >> Funny thing is nobody is calling this function. Maybe, I should just kill it > >> instead. > > Yes, delete it. Why doesn't the build warn about it not being used? > > > > OK. Because it is in a header file that nobody includes. Even better, just delete the whole file! :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Wed, 22 Nov 2017 17:58:29 +0100 Subject: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot() In-Reply-To: <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-30-git-send-email-okaya@codeaurora.org> <20171122075345.GC26583@kroah.com> <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> <20171122164546.GB30812@kroah.com> <3cca8693-72bf-db72-f698-f111c9ef707c@codeaurora.org> Message-ID: <20171122165829.GA2651@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 22, 2017 at 11:50:53AM -0500, Sinan Kaya wrote: > On 11/22/2017 11:45 AM, Greg Kroah-Hartman wrote: > >> Funny thing is nobody is calling this function. Maybe, I should just kill it > >> instead. > > Yes, delete it. Why doesn't the build warn about it not being used? > > > > OK. Because it is in a header file that nobody includes. Even better, just delete the whole file! :)