From: "Jérôme Carretero" <cJ-ko@zougloub.eu>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: WARNING: CPU: 3 PID: 20953 at /usr/src/linux/fs/btrfs/raid56.c:848 __free_raid_bio+0x8e/0xa0
Date: Thu, 23 Nov 2017 00:49:41 -0500 [thread overview]
Message-ID: <20171123004941.3f50b418@Vantage.cJ> (raw)
In-Reply-To: <20171122233534.GA8475@lim.localdomain>
Hi,
On Wed, 22 Nov 2017 15:35:35 -0800
Liu Bo <bo.li.liu@oracle.com> wrote:
> On Mon, Nov 20, 2017 at 02:00:07AM -0500, Jérôme Carretero wrote:
> > ------------[ cut here ]------------ [633254.461294] WARNING: CPU:
> > 3 PID: 20953 at /usr/src/linux/fs/btrfs/raid56.c:848
> > __free_raid_bio+0x8e/0xa0
>
>
> The vanilla 4.14.0 shows it is
> WARN_ON(!bio_list_empty(&rbio->bio_list)); but we just emptied
> rbio->bio_list two lines above, i.e. struct bio *cur =
> bio_list_get(&rbio->bio_list);
>
> Either we have some weird race, or the line number is misleading me.
>
> Can you please check the code which warning fs/btrfs/raid56.c:848
> points to?
Same code as yours:
WARN_ON(!bio_list_empty(&rbio->bio_list));
So yeah, at least git is not broken, now it could be a very weird
compiler bug or a less-weird race indeed...
Regards,
--
Jérôme
prev parent reply other threads:[~2017-11-23 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 7:00 WARNING: CPU: 3 PID: 20953 at /usr/src/linux/fs/btrfs/raid56.c:848 __free_raid_bio+0x8e/0xa0 Jérôme Carretero
2017-11-20 7:04 ` Jérôme Carretero
2017-11-22 23:35 ` Liu Bo
2017-11-23 5:49 ` Jérôme Carretero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123004941.3f50b418@Vantage.cJ \
--to=cj-ko@zougloub.eu \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.