From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org,
Konstantin Khorenko <khorenko@virtuozzo.com>,
Stuart Hayes <stuart.w.hayes@gmail.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] Ensure that the SCSI error handler gets woken up
Date: Thu, 23 Nov 2017 09:18:02 +0100 [thread overview]
Message-ID: <20171123081802.GA20705@lst.de> (raw)
In-Reply-To: <20171123010505.9603-1-bart.vanassche@wdc.com>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 5e89049e9b4e..f7f014c755d7 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -61,9 +61,10 @@ static int scsi_eh_try_stu(struct scsi_cmnd *scmd);
> static int scsi_try_to_abort_cmd(struct scsi_host_template *,
> struct scsi_cmnd *);
>
> -/* called with shost->host_lock held */
> void scsi_eh_wakeup(struct Scsi_Host *shost)
> {
> + lockdep_assert_held(shost->host_lock);
> +
> if (atomic_read(&shost->host_busy) == shost->host_failed) {
> trace_scsi_eh_wakeup(shost);
> wake_up_process(shost->ehandler);
Can you split this comment to assert change into a separate patch, please?
Except for that this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-11-23 8:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 1:05 [PATCH] Ensure that the SCSI error handler gets woken up Bart Van Assche
2017-11-23 1:05 ` Bart Van Assche
2017-11-23 8:18 ` Christoph Hellwig [this message]
2017-11-27 21:39 ` Bart Van Assche
2017-11-23 10:39 ` Johannes Thumshirn
2017-11-23 10:39 ` Johannes Thumshirn
2017-11-27 21:53 ` Stuart Hayes
2017-11-27 23:56 ` Bart Van Assche
2017-11-28 9:04 ` Pavel Tikhomirov
2017-11-28 15:33 ` Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2017-11-28 8:38 Pavel Tikhomirov
2017-11-28 8:54 Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123081802.GA20705@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=khorenko@virtuozzo.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.