From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: i915: enum intel_dpll_id cast Date: Thu, 23 Nov 2017 16:24:17 +0200 Message-ID: <20171123142417.GR10981@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D48A6E7C6 for ; Thu, 23 Nov 2017 14:24:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Kees Cook Cc: intel-gfx@lists.freedesktop.org, LKML , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMjIsIDIwMTcgYXQgMTI6NTQ6NDlQTSAtMDgwMCwgS2VlcyBDb29rIHdyb3Rl Ogo+IEhpLAo+IAo+IFdoaWxlIGRvaW5nIENsYW5nIHRlc3QgYnVpbGRzLCB0aGlzIHdhcyByZXBv cnRlZDoKPiAKPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYzoxNDgxOjMwOiB3YXJu aW5nOiBpbXBsaWNpdCBjb252ZXJzaW9uCj4gZnJvbSBlbnVtZXJhdGlvbiB0eXBlICdlbnVtIHBv cnQnIHRvIGRpZmZlcmVudCBlbnVtZXJhdGlvbiB0eXBlICdlbnVtCj4gaW50ZWxfZHBsbF9pZCcg Wy1XZW51bS1jb252ZXJzaW9uXQo+ICAgICAgICAgZW51bSBpbnRlbF9kcGxsX2lkIHBsbF9pZCA9 IHBvcnQ7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgfn5+fn5+ICAgXn5+fgo+IAo+IFdo aWNoIGlzIGZyb206Cj4gCj4gc3RhdGljIHZvaWQgYnh0X2RkaV9jbG9ja19nZXQoc3RydWN0IGlu dGVsX2VuY29kZXIgKmVuY29kZXIsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gewo+ICAgICAgICAgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5iYXNlLmRldik7 Cj4gICAgICAgICBlbnVtIHBvcnQgcG9ydCA9IGludGVsX2RkaV9nZXRfZW5jb2Rlcl9wb3J0KGVu Y29kZXIpOwo+ICAgICAgICAgZW51bSBpbnRlbF9kcGxsX2lkIHBsbF9pZCA9IHBvcnQ7Cj4gCj4g ICAgICAgICBwaXBlX2NvbmZpZy0+cG9ydF9jbG9jayA9IGJ4dF9jYWxjX3BsbF9saW5rKGRldl9w cml2LCBwbGxfaWQpOwo+IC4uLgo+IH0KPiAKPiBJbiBsb29raW5nIGF0IGl0LCBpdCBzZWVtcyB0 byBiZSBoYXJtbGVzcyBpZiBhcyBlbnVtIHBvcnQgaGFzIGEKPiBzbWFsbGVyIHJhbmdlIHRoYW4g ZW51bSBpbnRlbF9kcGxsX2lkLiBJIGp1c3Qgd2FudGVkIHRvIGNoZWNrIGlmIG1heWJlCj4gc29t ZXRoaW5nIG1pZ2h0IGdvIHdlaXJkLCBzaW5jZSBEUExMX0lEX0xDUExMXzI3MDAgbWF5YmUgZW5k cyB1cAo+IGdldHRpbmcgc2VlbiBhcyBJOTE1X01BWF9QT1JUUz8KCkJYVCBjYW4gb25seSBldmVy IGhhdmUgcG9ydCB2YWx1ZXMgUE9SVF9bQS1DXSBhbmQgdGhlIG1hdGNoaW5nCmRwbGxfaWQgdmFs dWVzIChEUExMX0lEX1NLTF9EUExMWzAtMl0pLCBzbyBpdCdzIGZpbmUuCgpBbHNvIHRoYXQgaW1w bGljaXQgY2FzdCBpcyBhY3R1YWxseSBnb25lIGZyb20gdGhlIGxhdGVzdCBjb2RlIHRoYW5rcwp0 byBjb21taXQgYmI5MTE1MzZmMDdlICgiZHJtL2k5MTU6IEVsaW1pbmF0ZSBwbGwtPnN0YXRlIHVz YWdlIGZyb20KYnh0X2NhbGNfcGxsX2xpbmsoKSIpLgoKPiAKPiBlbnVtIHBvcnQgewo+ICAgICAg ICAgUE9SVF9OT05FID0gLTEsCj4gICAgICAgICBQT1JUX0EgPSAwLAo+ICAgICAgICAgUE9SVF9C LAo+ICAgICAgICAgUE9SVF9DLAo+ICAgICAgICAgUE9SVF9ELAo+ICAgICAgICAgUE9SVF9FLAo+ ICAgICAgICAgSTkxNV9NQVhfUE9SVFMKPiB9Owo+IAo+IGVudW0gaW50ZWxfZHBsbF9pZCB7Cj4g Li4uCj4gICAgICAgICBEUExMX0lEX0xDUExMXzI3MDAgPSA1LAo+IC4uLgo+IH07Cj4gCj4gCj4g VGhhbmtzIQo+IAo+IC1LZWVzCj4gCj4gLS0gCj4gS2VlcyBDb29rCj4gUGl4ZWwgU2VjdXJpdHkK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146AbdKWOYX (ORCPT ); Thu, 23 Nov 2017 09:24:23 -0500 Received: from mga06.intel.com ([134.134.136.31]:9628 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753050AbdKWOYV (ORCPT ); Thu, 23 Nov 2017 09:24:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,441,1505804400"; d="scan'208";a="6189784" Date: Thu, 23 Nov 2017 16:24:17 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Kees Cook Cc: Rodrigo Vivi , intel-gfx@lists.freedesktop.org, LKML Subject: Re: [Intel-gfx] i915: enum intel_dpll_id cast Message-ID: <20171123142417.GR10981@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 22, 2017 at 12:54:49PM -0800, Kees Cook wrote: > Hi, > > While doing Clang test builds, this was reported: > > drivers/gpu/drm/i915/intel_ddi.c:1481:30: warning: implicit conversion > from enumeration type 'enum port' to different enumeration type 'enum > intel_dpll_id' [-Wenum-conversion] > enum intel_dpll_id pll_id = port; > ~~~~~~ ^~~~ > > Which is from: > > static void bxt_ddi_clock_get(struct intel_encoder *encoder, > struct intel_crtc_state *pipe_config) > { > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > enum port port = intel_ddi_get_encoder_port(encoder); > enum intel_dpll_id pll_id = port; > > pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id); > ... > } > > In looking at it, it seems to be harmless if as enum port has a > smaller range than enum intel_dpll_id. I just wanted to check if maybe > something might go weird, since DPLL_ID_LCPLL_2700 maybe ends up > getting seen as I915_MAX_PORTS? BXT can only ever have port values PORT_[A-C] and the matching dpll_id values (DPLL_ID_SKL_DPLL[0-2]), so it's fine. Also that implicit cast is actually gone from the latest code thanks to commit bb911536f07e ("drm/i915: Eliminate pll->state usage from bxt_calc_pll_link()"). > > enum port { > PORT_NONE = -1, > PORT_A = 0, > PORT_B, > PORT_C, > PORT_D, > PORT_E, > I915_MAX_PORTS > }; > > enum intel_dpll_id { > ... > DPLL_ID_LCPLL_2700 = 5, > ... > }; > > > Thanks! > > -Kees > > -- > Kees Cook > Pixel Security > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC