From: Sebastian Siewior <bigeasy@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH PREEMPT RT] rt-mutex: fix deadlock in device mapper
Date: Thu, 23 Nov 2017 15:42:31 +0100 [thread overview]
Message-ID: <20171123144231.GD2384@linutronix.de> (raw)
In-Reply-To: <1511299251.30074.72.camel@gmx.de>
On 2017-11-21 22:20:51 [+0100], Mike Galbraith wrote:
> On Tue, 2017-11-21 at 14:56 -0500, Mikulas Patocka wrote:
> >
> > If we don't have any reason why it is needed to unplug block requests when
> > a spinlock is taken - so let's not do this.
>
> That's perfectly fine. I guess I shouldn't have even mentioned having
> encountered unplug at mutex being insufficient.
While at it, I intend to drop
fs-jbd2-pull-your-plug-when-waiting-for-space.patch from the -RT queue
for v4.14 which does
--- a/fs/jbd2/checkpoint.c
+++ b/fs/jbd2/checkpoint.c
@@ -116,6 +116,8 @@ void __jbd2_log_wait_for_space(journal_t
nblocks = jbd2_space_needed(journal);
while (jbd2_log_space_left(journal) < nblocks) {
write_unlock(&journal->j_state_lock);
+ if (current->plug)
+ io_schedule();
mutex_lock(&journal->j_checkpoint_mutex);
/*
and is/was probably a workaround for the missing schedule while blocking
on mutex/rwsem.
> -Mike
Sebastian
next prev parent reply other threads:[~2017-11-23 14:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 17:56 [PATCH PREEMPT RT] rt-mutex: fix deadlock in device mapper Mikulas Patocka
[not found] ` <20171114151415.d5tazbuhfbjugepg@linutronix.de>
2017-11-15 17:08 ` Mikulas Patocka
2017-11-17 14:57 ` Sebastian Siewior
2017-11-18 18:37 ` Mike Galbraith
2017-11-20 10:53 ` Sebastian Siewior
2017-11-20 12:43 ` Mike Galbraith
2017-11-20 13:49 ` Mike Galbraith
2017-11-20 21:31 ` Mikulas Patocka
2017-11-20 22:11 ` Mikulas Patocka
2017-11-20 21:33 ` Mikulas Patocka
2017-11-21 3:20 ` Mike Galbraith
2017-11-21 8:37 ` Thomas Gleixner
2017-11-21 9:18 ` Mike Galbraith
2017-11-21 16:11 ` Mikulas Patocka
2017-11-21 17:33 ` Mike Galbraith
2017-11-21 19:56 ` Mikulas Patocka
2017-11-21 21:20 ` Mike Galbraith
2017-11-23 14:42 ` Sebastian Siewior [this message]
2017-11-23 14:50 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123144231.GD2384@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpatocka@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.