All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregKH@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] USB: usbfs: Filter flags passed in from user space
Date: Thu, 23 Nov 2017 16:19:50 +0100	[thread overview]
Message-ID: <20171123151950.GA26798@kroah.com> (raw)
In-Reply-To: <1511449588.27393.0.camel@suse.com>

On Thu, Nov 23, 2017 at 04:06:28PM +0100, Oliver Neukum wrote:
> Am Donnerstag, den 23.11.2017, 15:57 +0100 schrieb Greg KH:
> > On Thu, Nov 23, 2017 at 03:28:34PM +0100, Oliver Neukum wrote:
> > > 
> > > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints.
> > > Improve sanity checking.
> > > 
> > > Signed-off-by: Oliver Neukum <oneukum@suse.com>
> > > ---
> > >  drivers/usb/core/devio.c | 16 ++++++++++------
> > >  1 file changed, 10 insertions(+), 6 deletions(-)
> > 
> > Didn't we do something like this already?
> 
> I sent a patch. Alan found it insufficient.

Ah, ok.

> > Or was it something else?  Was this triggered by some testing?
> 
> Alexey's syzkaller tests showed that you can trigger it.

Then a nice "Reported-by:" would be good to add, as would a stable tree
inclusion, right?

thanks,

greg k-h

      reply	other threads:[~2017-11-23 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 14:28 [PATCH] USB: usbfs: Filter flags passed in from user space Oliver Neukum
2017-11-23 14:57 ` Greg KH
2017-11-23 15:06   ` Oliver Neukum
2017-11-23 15:19     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171123151950.GA26798@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.