All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ben Gainey <ben.gainey@arm.com>, Stephane Eranian <eranian@google.com>
Cc: Kim Phillips <kim.phillips@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Darren Hart <dvhart@infradead.org>,
	Colin Ian King <colin.king@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code
Date: Thu, 23 Nov 2017 12:22:27 -0300	[thread overview]
Message-ID: <20171123152227.GG8789@kernel.org> (raw)
In-Reply-To: <20171122182541.d25599a3eb1ada3480d142fa@arm.com>

Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu:
> From: Ben Gainey <ben.gainey@arm.com>
> @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
>  		return -1;
>  	}
>  
> -	flen = strlen(file) + 1;
> +	for (i = 0; i < nr_lines; ++i) {
> +	    flen += strlen(file_names[i]) + 1;
> +	}


Please follow the coding standard used in this file and in tools/perf,
which is the kernel one.

Thanks for providing instructions on how to reproduce the problem!

Stephane, can you please Ack this?

- Arnaldo

  reply	other threads:[~2017-11-23 15:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23  0:25 [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code Kim Phillips
2017-11-23 15:22 ` Arnaldo Carvalho de Melo [this message]
2017-11-28  3:21   ` [PATCH v2] " Kim Phillips
2017-11-29 13:02   ` [PATCH 3/3] " Stephane Eranian
2017-11-29 16:27     ` Ben Gainey
2017-12-07  3:35       ` Stephane Eranian
2017-12-18 17:16 ` [tip:perf/urgent] perf jvmti: Generate " tip-bot for Ben Gainey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171123152227.GG8789@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ben.gainey@arm.com \
    --cc=colin.king@canonical.com \
    --cc=dvhart@infradead.org \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.