From: jgg@mellanox.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: Allow rtc drivers to specify the tv_nsec value for ntp
Date: Thu, 23 Nov 2017 09:33:14 -0700 [thread overview]
Message-ID: <20171123163314.GF18754@mellanox.com> (raw)
In-Reply-To: <20171123153637.kbqcd2jsek4ybeic@piout.net>
On Thu, Nov 23, 2017 at 04:36:37PM +0100, Alexandre Belloni wrote:
> It wasn't sent to the RTC ML but that's fine.
Okay, my mistake.
> > Like Russell has said already, the kernel is the only place that could
> > actually have all the information needed. User space would have to use
> > some kind of trail and error approach to figure out what the offset
> > should be.
>
> And I don't see how this is different from doing it in the kernel.
Well, the kernel is closer to the RTC and can issue a single I2C
operation to directly measure bus latency, so it is in a far better
place to do this than user space...
> You currently don't give any feedback loop so the RTC driver doesn't
> know whether it's own offset is correct or not.
Feedback would be very complicated, that seems reasonable to push it
to userspace if people care enough to trim the RTC set very finely.
Allowing userspace to trim set offset from the driver would be
trivial.
Remember, the main goal here is to get bulk accuracy, by supporting
the RTC HW specific offset, which is currently wrong by 0.5s or more
on a lot of RTC hardware.
Jason
next prev parent reply other threads:[~2017-11-23 16:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 17:54 [PATCH] rtc: Allow rtc drivers to specify the tv_nsec value for ntp Jason Gunthorpe
2017-11-23 9:54 ` Alexandre Belloni
2017-11-23 11:23 ` Russell King - ARM Linux
2017-11-23 12:04 ` Alexandre Belloni
2017-11-23 12:04 ` Alexandre Belloni
2017-11-23 12:53 ` Russell King - ARM Linux
2017-11-23 12:53 ` Russell King - ARM Linux
2017-11-24 0:13 ` J William Piggott
2017-11-24 0:13 ` J William Piggott
2017-11-27 20:18 ` Alexandre Belloni
2017-11-27 20:18 ` Alexandre Belloni
2017-11-27 20:29 ` Jason Gunthorpe
2017-11-27 20:29 ` Jason Gunthorpe
2017-11-28 10:03 ` Russell King - ARM Linux
2017-11-28 10:03 ` Russell King - ARM Linux
2017-11-23 15:04 ` Jason Gunthorpe
2017-11-23 15:36 ` Alexandre Belloni
2017-11-23 16:10 ` Russell King - ARM Linux
2017-11-23 16:25 ` Russell King - ARM Linux
2017-11-27 18:48 ` Alexandre Belloni
2017-11-23 16:33 ` Jason Gunthorpe [this message]
2017-11-27 15:43 ` Russell King - ARM Linux
2017-11-27 17:43 ` Russell King - ARM Linux
2017-11-27 18:59 ` Jason Gunthorpe
2017-11-27 17:35 ` John Stultz
2017-11-27 17:52 ` Russell King - ARM Linux
2017-11-27 18:44 ` Alexandre Belloni
2017-11-27 18:53 ` Russell King - ARM Linux
2017-11-27 19:18 ` Russell King - ARM Linux
2017-11-27 19:31 ` Alexandre Belloni
2017-11-28 10:20 ` Russell King - ARM Linux
2017-11-30 19:39 ` Alexandre Belloni
2017-11-30 19:39 ` Alexandre Belloni
2017-11-30 19:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123163314.GF18754@mellanox.com \
--to=jgg@mellanox.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.