diff for duplicates of <20171123170642.GA28855@cbox> diff --git a/a/1.txt b/N1/1.txt index f31e132..a8c997a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -40,16 +40,16 @@ the critical path, but is just wrong, IMHO. > > I can suggest a third approach: > -> if (ioctl = KVM_GET_ONE_REG || ioctl = KVM_SET_ONE_REG) +> if (ioctl == KVM_GET_ONE_REG || ioctl == KVM_SET_ONE_REG) > return kvm_arch_vcpu_ioctl(filp, ioctl, arg); > > in kvm_vcpu_ioctl before "r = vcpu_load(vcpu);", or even better: > -> if (ioctl = KVM_GET_ONE_REG) +> if (ioctl == KVM_GET_ONE_REG) > // call kvm_arch_vcpu_get_one_reg_ioctl(vcpu, ®); > // and do copy_to_user > return kvm_vcpu_get_one_reg_ioctl(vcpu, arg); -> if (ioctl = KVM_SET_ONE_REG) +> if (ioctl == KVM_SET_ONE_REG) > // do copy_from_user then call > // kvm_arch_vcpu_set_one_reg_ioctl(vcpu, ®); > return kvm_vcpu_set_one_reg_ioctl(vcpu, arg); diff --git a/a/content_digest b/N1/content_digest index 030ead5..c205f19 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\072357599-798d-14d0-336a-69a083f17863@redhat.com\0" "From\0Christoffer Dall <cdall@linaro.org>\0" "Subject\0Re: [RFC PATCH] KVM: Only register preempt notifiers and load arch cpu state as needed\0" - "Date\0Thu, 23 Nov 2017 17:06:42 +0000\0" + "Date\0Thu, 23 Nov 2017 18:06:42 +0100\0" "To\0Paolo Bonzini <pbonzini@redhat.com>\0" "Cc\0Christoffer Dall <christoffer.dall@linaro.org>" kvm@vger.kernel.org @@ -62,16 +62,16 @@ "> \n" "> I can suggest a third approach:\n" "> \n" - "> if (ioctl = KVM_GET_ONE_REG || ioctl = KVM_SET_ONE_REG)\n" + "> if (ioctl == KVM_GET_ONE_REG || ioctl == KVM_SET_ONE_REG)\n" "> return kvm_arch_vcpu_ioctl(filp, ioctl, arg);\n" "> \n" "> in kvm_vcpu_ioctl before \"r = vcpu_load(vcpu);\", or even better:\n" "> \n" - "> if (ioctl = KVM_GET_ONE_REG)\n" + "> if (ioctl == KVM_GET_ONE_REG)\n" "> \t\t// call kvm_arch_vcpu_get_one_reg_ioctl(vcpu, ®);\n" "> \t\t// and do copy_to_user\n" "> \t\treturn kvm_vcpu_get_one_reg_ioctl(vcpu, arg);\n" - "> if (ioctl = KVM_SET_ONE_REG)\n" + "> if (ioctl == KVM_SET_ONE_REG)\n" "> \t\t// do copy_from_user then call\n" "> \t\t// kvm_arch_vcpu_set_one_reg_ioctl(vcpu, ®);\n" "> \t\treturn kvm_vcpu_set_one_reg_ioctl(vcpu, arg);\n" @@ -88,4 +88,4 @@ "Thanks,\n" -Christoffer -e07e4c42e2cfc27642a43aa6e46c5e9d84858a757142010f0dfa0fdcc150284c +1b524a4450ff3cb5f1a67ec8f6b400f255e51943883916c3e5516b0c87bacb1c
diff --git a/a/1.txt b/N2/1.txt index f31e132..a8c997a 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -40,16 +40,16 @@ the critical path, but is just wrong, IMHO. > > I can suggest a third approach: > -> if (ioctl = KVM_GET_ONE_REG || ioctl = KVM_SET_ONE_REG) +> if (ioctl == KVM_GET_ONE_REG || ioctl == KVM_SET_ONE_REG) > return kvm_arch_vcpu_ioctl(filp, ioctl, arg); > > in kvm_vcpu_ioctl before "r = vcpu_load(vcpu);", or even better: > -> if (ioctl = KVM_GET_ONE_REG) +> if (ioctl == KVM_GET_ONE_REG) > // call kvm_arch_vcpu_get_one_reg_ioctl(vcpu, ®); > // and do copy_to_user > return kvm_vcpu_get_one_reg_ioctl(vcpu, arg); -> if (ioctl = KVM_SET_ONE_REG) +> if (ioctl == KVM_SET_ONE_REG) > // do copy_from_user then call > // kvm_arch_vcpu_set_one_reg_ioctl(vcpu, ®); > return kvm_vcpu_set_one_reg_ioctl(vcpu, arg); diff --git a/a/content_digest b/N2/content_digest index 030ead5..b499758 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,23 +1,9 @@ "ref\020171123160521.27260-1-christoffer.dall@linaro.org\0" "ref\072357599-798d-14d0-336a-69a083f17863@redhat.com\0" - "From\0Christoffer Dall <cdall@linaro.org>\0" - "Subject\0Re: [RFC PATCH] KVM: Only register preempt notifiers and load arch cpu state as needed\0" - "Date\0Thu, 23 Nov 2017 17:06:42 +0000\0" - "To\0Paolo Bonzini <pbonzini@redhat.com>\0" - "Cc\0Christoffer Dall <christoffer.dall@linaro.org>" - kvm@vger.kernel.org - Andrew Jones <drjones@redhat.com> - " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Marc Zyngier <marc.zyngier@arm.com> - kvmarm@lists.cs.columbia.edu - linux-arm-kernel@lists.infradead.org - James Hogan <jhogan@kernel.org> - linux-mips@linux-mips.org - Alexander Graf <agraf@suse.com> - kvm-ppc@vger.kernel.org - Christian Borntraeger <borntraeger@de.ibm.com> - Cornelia Huck <cohuck@redhat.com> - " linux-s390@vger.kernel.org\0" + "From\0cdall@linaro.org (Christoffer Dall)\0" + "Subject\0[RFC PATCH] KVM: Only register preempt notifiers and load arch cpu state as needed\0" + "Date\0Thu, 23 Nov 2017 18:06:42 +0100\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, Nov 23, 2017 at 05:17:00PM +0100, Paolo Bonzini wrote:\n" @@ -62,16 +48,16 @@ "> \n" "> I can suggest a third approach:\n" "> \n" - "> if (ioctl = KVM_GET_ONE_REG || ioctl = KVM_SET_ONE_REG)\n" + "> if (ioctl == KVM_GET_ONE_REG || ioctl == KVM_SET_ONE_REG)\n" "> return kvm_arch_vcpu_ioctl(filp, ioctl, arg);\n" "> \n" "> in kvm_vcpu_ioctl before \"r = vcpu_load(vcpu);\", or even better:\n" "> \n" - "> if (ioctl = KVM_GET_ONE_REG)\n" + "> if (ioctl == KVM_GET_ONE_REG)\n" "> \t\t// call kvm_arch_vcpu_get_one_reg_ioctl(vcpu, ®);\n" "> \t\t// and do copy_to_user\n" "> \t\treturn kvm_vcpu_get_one_reg_ioctl(vcpu, arg);\n" - "> if (ioctl = KVM_SET_ONE_REG)\n" + "> if (ioctl == KVM_SET_ONE_REG)\n" "> \t\t// do copy_from_user then call\n" "> \t\t// kvm_arch_vcpu_set_one_reg_ioctl(vcpu, ®);\n" "> \t\treturn kvm_vcpu_set_one_reg_ioctl(vcpu, arg);\n" @@ -88,4 +74,4 @@ "Thanks,\n" -Christoffer -e07e4c42e2cfc27642a43aa6e46c5e9d84858a757142010f0dfa0fdcc150284c +bb011bf34289f702eea79311dde5bd7f732db205bb395207a6072bda983e2e3c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.