From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288AbdKWSlu (ORCPT ); Thu, 23 Nov 2017 13:41:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:56562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbdKWSlt (ORCPT ); Thu, 23 Nov 2017 13:41:49 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C7ED21921 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 23 Nov 2017 15:41:44 -0300 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Adrian Hunter , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf intel-pt: Improve build messages for files that differ from the kernel Message-ID: <20171123184144.GM8789@kernel.org> References: <1511253326-22308-1-git-send-email-adrian.hunter@intel.com> <1511253326-22308-2-git-send-email-adrian.hunter@intel.com> <20171121084111.y6p5zwqso2cbms5s@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171121084111.y6p5zwqso2cbms5s@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Nov 21, 2017 at 09:41:11AM +0100, Ingo Molnar escreveu: > * Adrian Hunter wrote: > > + ((diff -B -I'^#include' util/intel-pt-decoder/inat_types.h ../../arch/x86/include/asm/inat_types.h >/dev/null) || \ > > + (echo "Warning: Intel PT: x86 instruction decoder header at 'tools/perf/util/intel-pt-decoder/inat_types.h' differs from latest version at 'arch/x86/include/asm/inat_types.h'" >&2)))) || true > > $(call rule_mkdir) > > $(call if_changed_dep,cc_o_c) > > Could we please factor this out into a helper, sharing more code with > tools/perf/check-headers.sh? I'll do that at some point, applying the patch as the message got improved. > Also, I'd suggest removing this from check-headers.sh: > > opts="--ignore-blank-lines --ignore-space-change" Done already. - Arnaldo