All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/1] package/waylandpp: new package
Date: Thu, 23 Nov 2017 22:15:44 +0100	[thread overview]
Message-ID: <20171123221544.775472da@windsurf.lan> (raw)
In-Reply-To: <20171122183420.4544-1-bernd.kuhls@t-online.de>

Hello,

On Wed, 22 Nov 2017 19:34:20 +0100, Bernd Kuhls wrote:

> diff --git a/package/waylandpp/Config.in b/package/waylandpp/Config.in
> new file mode 100644
> index 0000000000..726653421c
> --- /dev/null
> +++ b/package/waylandpp/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_WAYLANDPP
> +	bool "waylandpp"
> +	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND

It is quite surprising that it needs libegl unconditionally, while
Wayland does not. But that's indeed what upstream requires, so...

> +	depends on BR2_HOST_GCC_AT_LEAST_4_9
> +	depends on !BR2_STATIC_LIBS # wayland
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
> +	select BR2_PACKAGE_WAYLAND

I've use a "depends on BR2_PACKAGE_WAYLAND" instead, because it's
obvious if you want Wayland C++ bindings that you need to enable
wayland first. Thanks to this I've dropped the thread and !static
dependencies.

Applied to next with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-11-23 21:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 18:34 [Buildroot] [PATCH v6 1/1] package/waylandpp: new package Bernd Kuhls
2017-11-23 21:15 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171123221544.775472da@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.