From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF
Date: Fri, 24 Nov 2017 03:28:26 +0100
Message-ID: <20171124022826.GA32569@lunn.ch>
References: <5A16B873.1060709@broadcom.com>
 <20171123140459.GC30167@lunn.ch>
 <CAF7Mx6pPBVr7PK1APpxqe1xF_pu7c1xWKZZiUDzQdXtAwut8HQ@mail.gmail.com>
 <CAF7Mx6pZ+19QQtV9yxU9pJu1+bd16=g6jzPD+rBUOp88h-0bsA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Arnd Bergmann <arnd@arndb.de>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:34209 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751505AbdKXC22 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 23 Nov 2017 21:28:28 -0500
Content-Disposition: inline
In-Reply-To: <CAF7Mx6pZ+19QQtV9yxU9pJu1+bd16=g6jzPD+rBUOp88h-0bsA@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Nov 23, 2017 at 08:27:48PM +0100, Arend Van Spriel wrote:
> + Arnd
> 
> On Thu, Nov 23, 2017 at 8:12 PM, Arend Van Spriel
> <arend.vanspriel@broadcom.com> wrote:
> > On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> >> On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote:
> >>> Compilation fails building on x86_64 platform which does not
> >>> have CONFIG_OF enabled.
> >>>
> >>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> >>> ---
> >>> After rebasing my branch to v4.14 I attempted to build the kernel and hit
> >>> the following compile issue:
> >>>
> >>> net/dsa/dsa2.c: In function \u2018dsa_switch_parse_member_of\u2019:
> >>> net/dsa/dsa2.c:678:2: error: implicit declaration of function
> >>> 'of_property_read_variable_u32_array'
> >>
> >> Hi Arend
> >>
> >> https://lkml.org/lkml/2017/11/6/493
> >
> > So my email/patch did get through initially. Sorry for the noise and
> > thanks for the info.
> 
> Hi Andrew,
> 
> Getting back to this. It seems that this patch did not get in. At
> least I searched for it in v4.14.1 but no luck.

Hi Arned

The use of of_property_read_variable_u32_array was added in
975e6e32215e ("net: dsa: rework switch parsing"). This patch is not in
v4.14. It is in linus/master, so v4.15-rc1 should have it. And the fix
is also in linus/master.

So there does not appear to be anything wrong. I just built v4.14.1
for x86_64 with DSA without problems.

   Andrew