From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753747AbdKXPxw (ORCPT ); Fri, 24 Nov 2017 10:53:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60822 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753520AbdKXPxu (ORCPT ); Fri, 24 Nov 2017 10:53:50 -0500 Date: Fri, 24 Nov 2017 16:53:55 +0100 From: Greg KH To: Fabian Baumanis Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, hsweeten@visionengravers.com, larturus@yahoo.com Subject: Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue Message-ID: <20171124155355.GA30433@kroah.com> References: <20dcf3e7-7621-a6d1-d50a-0c52e6dcdae3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20dcf3e7-7621-a6d1-d50a-0c52e6dcdae3@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 18, 2017 at 06:46:38PM +0100, Fabian Baumanis wrote: > Removed uneccessary parantheses which were sorrounding two > if-statements. > > Signed-off-by: Fabian Baumanis > --- >  drivers/staging/comedi/drivers/adl_pci9118.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c > index 1cc9b7e..c77b994 100644 > --- a/drivers/staging/comedi/drivers/adl_pci9118.c > +++ b/drivers/staging/comedi/drivers/adl_pci9118.c > @@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) >         devpriv->ai_add_back = 0; >         if (devpriv->master) { >                 devpriv->usedma = 1; > -               if ((cmd->flags & CMDF_WAKE_EOS) && > -                   (cmd->scan_end_arg == 1)) { > +               if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) { Ick, no, now I need to remember which has higher precedence, "&" or "&&". It's "&" right? I should not have to go look it up. The code as-is is just fine. thanks, greg k-h