From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Hailin Subject: Re: [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type Date: Fri, 24 Nov 2017 17:59:09 +0800 Message-ID: <2017112417590937512732@arraynetworks.com.cn> References: <20171117063635.9244-1-chenhl@arraynetworks.com.cn>, Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev , "ovs-dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org" , Maxime Coquelin , qemu-devel , cloud To: Aaron Conole , jianfeng.tan Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: dev.dpdk.org Hi Aaron Conole && Jianfeng, The stp could not work in ovs-dpdk vhostuser. Because the attached vhost device doesn't have MAC address. Now we have two ways to solve this problem. 1. The vhost learns MAC address from packet like as my first patch. 2. The virtio notifies MAC address actively to vhost user . In my opinions, if we treat it as a device, we should allocate MAC address for the device when the VM started. Which one do you think better? Best Regards, Chen Hailin chenhl-rzYryr47tH9qO0yjgLDq52/U75nxZMCp@public.gmane.org From: Aaron Conole Date: 2017-11-18 10:00 To: Hailin Chen CC: ovs-dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org; Maxime Coquelin; cloud-rzYryr47tH9qO0yjgLDq52/U75nxZMCp@public.gmane.org Subject: Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type Hi Hailin, Hailin Chen writes: > The stp could not work on netdev-dpdk if network is loop. > Because the stp protocol negotiates designate port by sending > BPDU packets which contains MAC address. > However the device doesn't have MAC address in vhostuser type. > Thus, function send_bpdu_cb would not send BPDU packets. > > This patch will set the MAC for device when received first packet. > > Signed-off-by: Hailin Chen > --- Thanks for the patch. In general, I don't think this is the right approach to deal with this type of issue. I believe the problem statement is that OvS bridge is unaware of the guest MAC address - did I get it right? In that case, I would think that a better way to solve this would be to have virtio tell the mac address of the guest. I don't recall right now if that's allowed in the virtio spec, but I do remember some kind of negotiation features. I've CC'd Maxime, who is one of the maintainers of the virtio code from DPDK side. Perhaps there is an alternate way to solve this. _______________________________________________ dev mailing list dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIB5Y-0001Ta-NY for qemu-devel@nongnu.org; Fri, 24 Nov 2017 05:20:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIB5S-0005KS-Ac for qemu-devel@nongnu.org; Fri, 24 Nov 2017 05:20:04 -0500 Received: from mail.arraynetworks.com.cn ([124.42.99.121]:30090 helo=mail01.arraynetworks.com.cn) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eIB5R-0005C3-FH for qemu-devel@nongnu.org; Fri, 24 Nov 2017 05:19:58 -0500 Date: Fri, 24 Nov 2017 17:59:09 +0800 From: Chen Hailin References: <20171117063635.9244-1-chenhl@arraynetworks.com.cn>, MIME-Version: 1.0 Message-ID: <2017112417590937512732@arraynetworks.com.cn> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Subject: Re: [Qemu-devel] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aaron Conole , "jianfeng.tan" Cc: "ovs-dev@openvswitch.org" , Maxime Coquelin , cloud , qemu-devel , dev SGkgQWFyb24gQ29ub2xlICYmIEppYW5mZW5nLA0KDQpUaGUgc3RwIGNvdWxkIG5vdCB3b3JrIGlu IG92cy1kcGRrIHZob3N0dXNlci4NCkJlY2F1c2UgdGhlIGF0dGFjaGVkIHZob3N0IGRldmljZSBk b2Vzbid0IGhhdmUgTUFDIGFkZHJlc3MuDQoNCk5vdyB3ZSBoYXZlIHR3byB3YXlzIHRvIHNvbHZl IHRoaXMgcHJvYmxlbS4NCjEuIFRoZSB2aG9zdCBsZWFybnMgTUFDIGFkZHJlc3MgZnJvbSBwYWNr ZXQgbGlrZSBhcyBteSBmaXJzdCBwYXRjaC4NCjIuIFRoZSB2aXJ0aW8gbm90aWZpZXMgTUFDIGFk ZHJlc3MgYWN0aXZlbHkgdG8gdmhvc3QgdXNlciAuDQoNCkluIG15IG9waW5pb25zLCAgaWYgd2Ug dHJlYXQgaXQgYXMgYSBkZXZpY2UsICB3ZSBzaG91bGQgYWxsb2NhdGUgDQpNQUMgYWRkcmVzcyBm b3IgdGhlIGRldmljZSB3aGVuIHRoZSBWTSBzdGFydGVkLg0KDQpXaGljaCBvbmUgZG8geW91IHRo aW5rIGJldHRlcj8NCg0KDQoNCkJlc3QgUmVnYXJkcywNCkNoZW4gSGFpbGluDQpjaGVuaGxAYXJy YXluZXR3b3Jrcy5jb20uY24NCiANCkZyb206IEFhcm9uIENvbm9sZQ0KRGF0ZTogMjAxNy0xMS0x OCAxMDowMA0KVG86IEhhaWxpbiBDaGVuDQpDQzogb3ZzLWRldkBvcGVudnN3aXRjaC5vcmc7IE1h eGltZSBDb3F1ZWxpbjsgY2xvdWRAYXJyYXluZXR3b3Jrcy5jb20uY24NClN1YmplY3Q6IFJlOiBb b3ZzLWRldl0gW1BBVENIIFJGQ10gbmV0ZGV2LWRwZGs6IEZpeCBkZXZpY2Ugb2J0YWluIG1hYyBh ZGRyZXNzIHdoZW4gcmVjZWl2ZWQgZmlyc3QgcGFja2V0IGluIHZob3N0IHR5cGUNCkhpIEhhaWxp biwNCiANCkhhaWxpbiBDaGVuIDxjaGVuaGxAYXJyYXluZXR3b3Jrcy5jb20uY24+IHdyaXRlczoN CiANCj4gVGhlIHN0cCBjb3VsZCBub3Qgd29yayBvbiBuZXRkZXYtZHBkayBpZiBuZXR3b3JrIGlz IGxvb3AuDQo+IEJlY2F1c2UgdGhlIHN0cCBwcm90b2NvbCBuZWdvdGlhdGVzIGRlc2lnbmF0ZSBw b3J0IGJ5IHNlbmRpbmcNCj4gQlBEVSBwYWNrZXRzIHdoaWNoIGNvbnRhaW5zIE1BQyBhZGRyZXNz Lg0KPiBIb3dldmVyIHRoZSBkZXZpY2UgZG9lc24ndCBoYXZlIE1BQyBhZGRyZXNzIGluIHZob3N0 dXNlciB0eXBlLg0KPiBUaHVzLCBmdW5jdGlvbiBzZW5kX2JwZHVfY2Igd291bGQgbm90IHNlbmQg QlBEVSBwYWNrZXRzLg0KPg0KPiBUaGlzIHBhdGNoIHdpbGwgc2V0IHRoZSBNQUMgZm9yIGRldmlj ZSB3aGVuIHJlY2VpdmVkIGZpcnN0IHBhY2tldC4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSGFpbGlu IENoZW4gPGNoZW5obEBhcnJheW5ldHdvcmtzLmNvbS5jbj4NCj4gLS0tDQogDQpUaGFua3MgZm9y IHRoZSBwYXRjaC4NCiANCkluIGdlbmVyYWwsIEkgZG9uJ3QgdGhpbmsgdGhpcyBpcyB0aGUgcmln aHQgYXBwcm9hY2ggdG8gZGVhbCB3aXRoIHRoaXMNCnR5cGUgb2YgaXNzdWUuICBJIGJlbGlldmUg dGhlIHByb2JsZW0gc3RhdGVtZW50IGlzIHRoYXQgT3ZTIGJyaWRnZSBpcw0KdW5hd2FyZSBvZiB0 aGUgZ3Vlc3QgTUFDIGFkZHJlc3MgLSBkaWQgSSBnZXQgaXQgcmlnaHQ/ICBJbiB0aGF0IGNhc2Us IEkNCndvdWxkIHRoaW5rIHRoYXQgYSBiZXR0ZXIgd2F5IHRvIHNvbHZlIHRoaXMgd291bGQgYmUg dG8gaGF2ZSB2aXJ0aW8gdGVsbA0KdGhlIG1hYyBhZGRyZXNzIG9mIHRoZSBndWVzdC4gIEkgZG9u J3QgcmVjYWxsIHJpZ2h0IG5vdyBpZiB0aGF0J3MNCmFsbG93ZWQgaW4gdGhlIHZpcnRpbyBzcGVj LCBidXQgSSBkbyByZW1lbWJlciBzb21lIGtpbmQgb2YgbmVnb3RpYXRpb24NCmZlYXR1cmVzLg0K IA0KSSd2ZSBDQydkIE1heGltZSwgd2hvIGlzIG9uZSBvZiB0aGUgbWFpbnRhaW5lcnMgb2YgdGhl IHZpcnRpbyBjb2RlIGZyb20NCkRQREsgc2lkZS4gIFBlcmhhcHMgdGhlcmUgaXMgYW4gYWx0ZXJu YXRlIHdheSB0byBzb2x2ZSB0aGlzLg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18NCmRldiBtYWlsaW5nIGxpc3QNCmRldkBvcGVudnN3aXRjaC5vcmcNCmh0 dHBzOi8vbWFpbC5vcGVudnN3aXRjaC5vcmcvbWFpbG1hbi9saXN0aW5mby9vdnMtZGV2DQo=