From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751136AbdKYIWn (ORCPT ); Sat, 25 Nov 2017 03:22:43 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34303 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbdKYIWl (ORCPT ); Sat, 25 Nov 2017 03:22:41 -0500 X-ME-Sender: Date: Sat, 25 Nov 2017 19:22:36 +1100 From: "Tobin C. Harding" To: Greg Kroah-Hartman Cc: Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Ulf Hansson , Jani Nikula , Dan Williams Subject: Re: [PATCH v2] doc: add maintainer book Message-ID: <20171125082236.GJ17858@eros> References: <1511559870-31111-1-git-send-email-me@tobin.cc> <20171125075623.GC8786@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171125075623.GC8786@kroah.com> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 25, 2017 at 08:56:23AM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 25, 2017 at 08:44:19AM +1100, Tobin C. Harding wrote: > > There is currently very little documentation in the kernel on maintainer > > level tasks. In particular there are no documents on creating pull > > requests to submit to Linus. > > > > Quoting Greg Kroah-Hartman on LKML: > > > > Anyway, this actually came up at the kernel summit / maintainer > > meeting a few weeks ago, in that "how do I make a > > good pull request to Linus" is something we need to document. > > > > Here's what I do, and it seems to work well, so maybe we should turn > > it into the start of the documentation for how to do it. > > > > (quote references: kernel summit, Europe 2017) > > > > Create a new kernel documentation book 'how to be a maintainer' > > (suggested by Jonathan Corbet). Add chapters on 'configuring git' and > > 'creating a pull request'. > > > > Most of the content was written by Linus Torvalds and Greg Kroah-Hartman > > in discussion on LKML. This is stated at the start of one of the > > chapters and the original email thread is referenced in > > 'pull-requests.rst'. > > > > Signed-off-by: Tobin C. Harding > > --- > > You dropped my reviewed-by :( Oh, I didn't realize I was able to keep it between versions. I realize this was a reasonably trivial change but in general how much change is ok while keeping the reviewed-by? Who's call is it, the original author, the reviewed-by dev or the maintainer? So v3 with your reviewed-by in the commit log below the signed-off tag. (ain't nothin like noise ;) thanks, Tobin.