From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] support/download: svn non-interactive in BR2_SVN
Date: Sat, 25 Nov 2017 16:11:49 +0100 [thread overview]
Message-ID: <20171125151149.GD2798@scaer> (raw)
In-Reply-To: <1510944634-3374-1-git-send-email-sam.voss@rockwellcollins.com>
Sam, All,
On 2017-11-17 12:50 -0600, Sam Voss spake thusly:
> Instead of overriding the _svn command and injecting --non-interactive,
> change the default value of BR2_SVN to include this flag so the end user
> can choose not to use the flag.
>
> This change helps users behind corporate system rules which may not
> allow them to locally cache credentials and require interactive mode.
>
> Signed-off-by: Sam Voss <sam.voss@rockwellcollins.com>
>
> [Originally implemented by]
> CC: "Yann E. MORIN" <yann.morin.1998@free.fr>
Thomas, since this is my code: ;-)
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Config.in | 2 +-
> support/download/svn | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Config.in b/Config.in
> index 90f793a..d192995 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -106,7 +106,7 @@ config BR2_WGET
>
> config BR2_SVN
> string "Subversion (svn) command"
> - default "svn"
> + default "svn --non-interactive"
>
> config BR2_BZR
> string "Bazaar (bzr) command"
> diff --git a/support/download/svn b/support/download/svn
> index ee799f4..ad84a39 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -33,7 +33,7 @@ _svn() {
> eval ${SVN} "${@}"
> }
>
> -_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> +_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>
> # If this is a HEAD revision, export the exact version
> # that was checked out.
> --
> 1.9.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-11-25 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 18:50 [Buildroot] [PATCH 1/1] support/download: svn non-interactive in BR2_SVN Sam Voss
2017-11-25 15:11 ` Yann E. MORIN [this message]
2017-11-26 13:41 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125151149.GD2798@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.