From: Daniel Scheller <d.scheller.oss@gmail.com>
To: linux-media@vger.kernel.org, mchehab@kernel.org,
mchehab@s-opensource.com
Cc: rjkm@metzlerbros.de, rascobie@slingshot.co.nz, jasmin@anw.at
Subject: [PATCH 4/7] [media] dvb-frontends/stv0910: remove unneeded check/call to get_if_freq
Date: Sun, 26 Nov 2017 14:00:06 +0100 [thread overview]
Message-ID: <20171126130009.6798-5-d.scheller.oss@gmail.com> (raw)
In-Reply-To: <20171126130009.6798-1-d.scheller.oss@gmail.com>
From: Daniel Scheller <d.scheller@gmx.net>
The result (if any) isn't used anywhere besides being assigned to a local
variable (and the only current companion stv6111 doesn't even implement
get_if_frequency()), thus remove the ptr check and the call, and also
remove the now unused iffreq variable.
Reported-by: Richard Scobie <rascobie@slingshot.co.nz>
Cc: Ralph Metzler <rjkm@metzlerbros.de>
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Tested-by: Richard Scobie <rascobie@slingshot.co.nz>
---
drivers/media/dvb-frontends/stv0910.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/stv0910.c b/drivers/media/dvb-frontends/stv0910.c
index cd247ab9c62d..074374fe00be 100644
--- a/drivers/media/dvb-frontends/stv0910.c
+++ b/drivers/media/dvb-frontends/stv0910.c
@@ -1273,14 +1273,11 @@ static int set_parameters(struct dvb_frontend *fe)
{
int stat = 0;
struct stv *state = fe->demodulator_priv;
- u32 iffreq;
struct dtv_frontend_properties *p = &fe->dtv_property_cache;
stop(state);
if (fe->ops.tuner_ops.set_params)
fe->ops.tuner_ops.set_params(fe);
- if (fe->ops.tuner_ops.get_if_frequency)
- fe->ops.tuner_ops.get_if_frequency(fe, &iffreq);
state->symbol_rate = p->symbol_rate;
stat = start(state, p);
return stat;
--
2.13.6
next prev parent reply other threads:[~2017-11-26 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 13:00 [PATCH 0/7] stv0910+stv6111 updates/fixes/improvements Daniel Scheller
2017-11-26 13:00 ` [PATCH 1/7] [media] frontends/stv0910: add field offsets to field defines Daniel Scheller
2017-11-26 13:00 ` [PATCH 2/7] [media] dvb-frontends/stv0910: WARN_ON() on consecutive mutex_unlock() Daniel Scheller
2017-11-26 13:00 ` [PATCH 3/7] [media] dvb-frontends/stv6111: handle gate_ctrl errors Daniel Scheller
2017-11-26 13:00 ` Daniel Scheller [this message]
2017-11-26 13:00 ` [PATCH 5/7] [media] dvb-frontends/stv0910: read symbolrate in get_frontend() Daniel Scheller
2017-11-26 13:00 ` [PATCH 6/7] [media] dvb-frontends/stv0910: remove unneeded symbol rate inquiry Daniel Scheller
2017-11-26 13:00 ` [PATCH 7/7] [media] dvb-frontends/stv0910: remove unneeded dvb_math.h include Daniel Scheller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171126130009.6798-5-d.scheller.oss@gmail.com \
--to=d.scheller.oss@gmail.com \
--cc=jasmin@anw.at \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
--cc=rascobie@slingshot.co.nz \
--cc=rjkm@metzlerbros.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.