From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Guenter Roeck <linux@roeck-us.net>,
Peter Huewe <peterhuewe@gmx.de>,
Andrey Pronin <apronin@chromium.org>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: Add explicit chip->ops locking for sysfs attributes.
Date: Sun, 26 Nov 2017 15:56:41 +0200 [thread overview]
Message-ID: <20171126135641.szdrrh2szzfowgew@linux.intel.com> (raw)
In-Reply-To: <20171121185856.GG18272@ziepe.ca>
On Tue, Nov 21, 2017 at 11:58:56AM -0700, Jason Gunthorpe wrote:
> On Tue, Nov 21, 2017 at 10:28:58AM -0800, Guenter Roeck wrote:
>
> > I'll split the patch into two parts, and only add (hopefully)
> > non-controversial tpm2 attributes for now (which I think is durations
> > and timeouts). Or, in other words, I'll split the attributes into
> > two groups - one generic and one for tpm1.
>
> Ok. Please look at new attributes you wish to add for tpm2 and see if
> they meet the modern sysfs sensibility of one value per file, etc.
>
> Jason
In general: if something can be retrieved through /dev/tpm0, there is no
any sane reason to have a sysfs attribute for such.
/Jarkko
next prev parent reply other threads:[~2017-11-26 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 21:25 [PATCH] tpm: Add explicit chip->ops locking for sysfs attributes Guenter Roeck
2017-11-20 22:13 ` Jarkko Sakkinen
2017-11-20 22:45 ` Guenter Roeck
2017-11-20 23:17 ` Jason Gunthorpe
2017-11-20 23:49 ` Jarkko Sakkinen
2017-11-21 18:28 ` Guenter Roeck
2017-11-21 18:58 ` Jason Gunthorpe
2017-11-26 13:56 ` Jarkko Sakkinen [this message]
2017-11-27 16:02 ` Guenter Roeck
2017-11-28 20:24 ` Jarkko Sakkinen
2017-11-20 23:45 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171126135641.szdrrh2szzfowgew@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=apronin@chromium.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.