From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] rtl8723bu: new package
Date: Mon, 27 Nov 2017 09:08:11 +0100 [thread overview]
Message-ID: <20171127090811.22628218@windsurf> (raw)
In-Reply-To: <20171126215913.28767-1-mylene.josserand@free-electrons.com>
Hello,
On Sun, 26 Nov 2017 22:59:13 +0100, Myl?ne Josserand wrote:
> Add RTL8723BU package to compile the Realtek RTL8723BU Wifi driver.
>
> Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>
Thanks for this contribution!
> package/Config.in | 1 +
> package/rtl8723bu/Config.in | 10 ++++++++++
> package/rtl8723bu/rtl8723bu.hash | 2 ++
> package/rtl8723bu/rtl8723bu.mk | 25 +++++++++++++++++++++++++
> 4 files changed, 38 insertions(+)
Could you add yourself to the DEVELOPERS file for this package?
> diff --git a/package/rtl8723bu/rtl8723bu.mk b/package/rtl8723bu/rtl8723bu.mk
> new file mode 100644
> index 0000000000..774caa02f9
> --- /dev/null
> +++ b/package/rtl8723bu/rtl8723bu.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# rtl8723bu
> +#
> +################################################################################
> +
> +RTL8723BU_VERSION = b922079a090dcaad58179d478442ff97f18521c9
> +RTL8723BU_SITE = $(call github,lwfinger,rtl8723bu,$(RTL8723BU_VERSION))
> +RTL8723BU_LICENSE = GPL-2.0, proprietary (*.bin firmware blobs)
> +
> +RTL8723BU_MODULE_MAKE_OPTS = \
> + KVER=$(LINUX_VERSION_PROBED) \
> + KSRC=$(LINUX_DIR)
> +
> +RTL8723BU_BINS = rtl8723b_fw.bin
> +
> +define RTL8723BU_INSTALL_FIRMWARE
> + $(foreach bin, $(RTL8723BU_BINS), \
> + $(INSTALL) -D -m 644 $(@D)/$(bin) $(TARGET_DIR)/lib/firmware/rtlwifi/$(bin)
> + )
The loop is not needed, since you have a single firmware file, so this
can be simplified as:
$(INSTALL) -D -m 0644 $(@D)/rtl8723b_fw.bin $(TARGET_DIR)/lib/firmware/rtlwifi/rtl8723b_fw.bin
> +endef
> +RTL8723BU_POST_INSTALL_TARGET_HOOKS += RTL8723BU_INSTALL_FIRMWARE
I know the rtl8723bs package that you probably used as an example does
this, but in fact there is no need to use a post install target hook
here. You can just do:
define RTL8723BU_INSTALL_TARGET_CMDS
$(INSTALL) -D ...
endef
Could you fix those minor details, and submit an updated version?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-27 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 21:59 [Buildroot] [PATCH] rtl8723bu: new package Mylène Josserand
2017-11-27 8:08 ` Thomas Petazzoni [this message]
2017-11-27 8:18 ` Mylene JOSSERAND
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127090811.22628218@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.