From: <jiang.biao2@zte.com.cn>
To: mhocko@kernel.org
Cc: minchan@kernel.org, akpm@linux-foundation.org,
hannes@cmpxchg.org, hillf.zj@alibaba-inc.com,
ying.huang@intel.com, linux-mm@kvack.org,
mgorman@techsingularity.net, linux-kernel@vger.kernel.org,
zhong.weidong@zte.com.cn
Subject: Re: [PATCH] mm/vmscan: make do_shrink_slab more robust.
Date: Mon, 27 Nov 2017 16:41:49 +0800 (CST) [thread overview]
Message-ID: <201711271641496179247@zte.com.cn> (raw)
In-Reply-To: <20171127082709.2lrc4wbxosv6uuv3@dhcp22.suse.cz>
[-- Attachment #1.1: Type: text/plain, Size: 565 bytes --]
On Mon 27-11-17 15:26:54, jiang.biao2@zte.com.cn wrote:
> >> > With all due respect. I still think the robustness is more important than
> > effectiveness in this case. :)
>
> This is a slow path so I wouldn't worry about the performance much. On
> the other hand I agree that the API is well documented so adding a
> warning is too defensive. We simply assume that the kernel running in
> the kernel is reasonable. So I would say, fix your code.
Ok, already send another patch for mbache shrinker to ensure non-minus
return.
Thank you for your reply :)
Regards,
prev parent reply other threads:[~2017-11-27 8:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 1:37 [PATCH] mm/vmscan: make do_shrink_slab more robust Jiang Biao
2017-11-27 1:37 ` Jiang Biao
2017-11-27 2:39 ` Minchan Kim
2017-11-27 2:39 ` Minchan Kim
2017-11-27 4:46 ` jiang.biao2
2017-11-27 5:16 ` Minchan Kim
2017-11-27 5:16 ` Minchan Kim
2017-11-27 6:27 ` jiang.biao2
2017-11-27 6:38 ` Minchan Kim
2017-11-27 6:38 ` Minchan Kim
2017-11-27 7:26 ` jiang.biao2
2017-11-27 8:27 ` Michal Hocko
2017-11-27 8:27 ` Michal Hocko
2017-11-27 8:41 ` jiang.biao2 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201711271641496179247@zte.com.cn \
--to=jiang.biao2@zte.com.cn \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=ying.huang@intel.com \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.