From: Thomas Meyer <thomas@m3y3r.de>
To: Randy Dunlap <rdunlap@infradead.org>, torvalds@linux-foundation.org
Cc: paul.burton@imgtec.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM
Date: Mon, 27 Nov 2017 21:05:37 +0100 [thread overview]
Message-ID: <20171127200537.GA3557@localhost.localdomain> (raw)
In-Reply-To: <ecc18d54-c1dd-6b8c-df7c-cc6d988a0c62@infradead.org>
On Thu, Aug 10, 2017 at 11:24:04AM -0700, Randy Dunlap wrote:
> On 08/10/2017 01:53 AM, Thomas Meyer wrote:
> > This avoids the MODPOST error:
> > ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!
> >
> > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> > ---
> > drivers/auxdisplay/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index 9ae6681c90ad..9088c66e4c08 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -135,6 +135,7 @@ config CFAG12864B_RATE
> >
> > config IMG_ASCII_LCD
> > tristate "Imagination Technologies ASCII LCD Display"
> > + depends on HAS_IOMEM
> > default y if MIPS_MALTA || MIPS_SEAD3
> > select SYSCON
> > help
> >
>
> I posted the same patch on 2017-JAN-01, so I agree with it.
>
> https://lkml.org/lkml/2017/1/1/87
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
No response from the maintainer yet. I think this driver is actually unmaintained.
What to do now?
>
> --
> ~Randy
next prev parent reply other threads:[~2017-11-27 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 8:53 [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM Thomas Meyer
2017-08-10 18:24 ` Randy Dunlap
2017-11-27 20:05 ` Thomas Meyer [this message]
2017-11-27 20:37 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127200537.GA3557@localhost.localdomain \
--to=thomas@m3y3r.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.burton@imgtec.com \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.